Merge pull request #126 from abouteiller/cleanup/unused-vars

Fix warnings found by clang17, some missing copyrights
ICLDisco · Oct 24, 2024 · 4ad5c19 · 4ad5c19
2 parents 316efd3 + 99ccf36
commit 4ad5c19
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 11 deletions.
diff --git a/src/dplasma_hqr_dbg.c b/src/dplasma_hqr_dbg.c
@@ -1,8 +1,10 @@
 /*
- * Copyright (c) 2010-2020 The University of Tennessee and The University
+ * Copyright (c) 2010-2024 The University of Tennessee and The University
  *                         of Tennessee Research Foundation.  All rights
  *                         reserved.
  *
+ * $COPYRIGHT
+ *
  * @precisions normal z -> s d c
  *
  *
@@ -304,7 +306,6 @@ void dplasma_qrtree_print_type( parsec_tiled_matrix_t *A, dplasma_qrtree_t *qrtr
 {
     int minMN = dplasma_imin(A->mt, A->nt );
     int m, k;
-    int lm = 0;
     int lmg = 0;
     int rank = 0;
 
@@ -326,11 +327,10 @@ void dplasma_qrtree_print_type( parsec_tiled_matrix_t *A, dplasma_qrtree_t *qrtr
         for (k=dplasma_imin(minMN, lmg+1); k<minMN; k++) {
             printf( "    " );
         }
-        lm++; lmg+=qrtree->p;
+        lmg+=qrtree->p;
         if ( lmg >= A->mt ) {
             rank++;
             lmg = rank;
-            lm = 0;
         }
         printf("\n");
     }
@@ -340,7 +340,6 @@ void dplasma_qrtree_print_pivot( parsec_tiled_matrix_t *A, dplasma_qrtree_t *qrt
 {
     int minMN = dplasma_imin(A->mt, A->nt );
     int m, k;
-    int lm = 0;
     int lmg = 0;
     int rank = 0;
     printf("\n------------ Current Pivot--------------\n");
@@ -361,11 +360,10 @@ void dplasma_qrtree_print_pivot( parsec_tiled_matrix_t *A, dplasma_qrtree_t *qrt
         for (k=dplasma_imin(minMN, lmg+1); k<minMN; k++) {
             printf( "    " );
         }
-        lm++; lmg+=qrtree->p;
+        lmg+=qrtree->p;
         if ( lmg >= A->mt ) {
             rank++;
             lmg = rank;
-            lm = 0;
         }
         printf("\n");
     }

diff --git a/src/utils/dplasma_arena_datatype.c b/src/utils/dplasma_arena_datatype.c
@@ -1,6 +1,15 @@
+/*
+ * Copyright (c) 2020-2024 The University of Tennessee and The University
+ *                         of Tennessee Research Foundation.  All rights
+ *                         reserved.
+ *
+ * $COPYRIGHT
+ *
+ */
 #include "dplasma_arena_datatype.h"
 #include <string.h>
 
+#ifdef REUSE_ARENA_DATATYPE
 static parsec_key_fn_t arena_key_fns = {
     .key_equal = parsec_hash_table_generic_64bits_key_equal,
     .key_print = parsec_hash_table_generic_64bits_key_print,
@@ -39,6 +48,7 @@ static parsec_key_fn_t dtt_key_fns = {
     .key_print = dtt_key_print,
     .key_hash = dtt_key_hash
 };
+#endif /* REUSE_ARENA_DATATYPE */
 
 parsec_hash_table_t *dplasma_arenas = NULL;
 parsec_hash_table_t *dplasma_datatypes = NULL;
@@ -53,6 +63,7 @@ static void dplasma_arenas_release(void *item, void*cb_data)
     free(arena_entry);
 }
 
+#ifdef REUSE_ARENA_DATATYPE
 static void dplasma_datatypes_release(void *item, void*cb_data)
 {
     (void)cb_data;
@@ -81,6 +92,7 @@ static void dplasma_datatypes_fini()
         PARSEC_OBJ_RELEASE(dplasma_datatypes);
     }
 }
+#endif /* REUSE_ARENA_DATATYPE */
 
 int dplasma_get_or_construct_arena(parsec_arena_t** parena,
                                    size_t elem_size,

diff --git a/src/zgetrf_qrf.jdf b/src/zgetrf_qrf.jdf
@@ -1,9 +1,10 @@
 extern "C" %{
 /*
- * Copyright (c) 2010-2020 The University of Tennessee and The University
+ * Copyright (c) 2010-2024 The University of Tennessee and The University
  *                         of Tennessee Research Foundation. All rights
  *                         reserved.
  * Copyright (c) 2013      Inria. All rights reserved.
+ *
  * $COPYRIGHT
  *
  * @precisions normal z -> s d c
@@ -1141,9 +1142,9 @@ BODY
             cond = k%2;
         }
 
-        if (alpha == 0)
+        if (alpha == 0.0)
             cond = 0;
-        if (alpha >= 9999999999)
+        if (alpha >= 1e10)
             cond = 1;
       cond_affect:
         lu_tab[k] = cond;

diff --git a/src/zpotrf_L.jdf b/src/zpotrf_L.jdf
@@ -148,7 +148,7 @@ END
 BODY [type=HIP]
 {
     int tempkm = k == descA->mt-1 ? descA->m - k*descA->mb : descA->mb;
-    int ldak = LDA(descA, T);
+    int ldak = LDA(ddescA, T);
 
     rocblas_status status;
     rocblas_fill rocblas_uplo;