feat: Add optional setup_file_server.yaml playbook #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Emery <[email protected]>
Signed-off-by: Jacob Emery <[email protected]>
Signed-off-by: Jacob Emery <[email protected]>
Signed-off-by: Jacob Emery <[email protected]>
Signed-off-by: Jacob Emery <[email protected]>
…rting disconnected installs. Signed-off-by: Jacob Emery <[email protected]>
Signed-off-by: Jacob Emery <[email protected]>
Signed-off-by: Jacob Emery <[email protected]>
Signed-off-by: Jacob Emery <[email protected]>
Signed-off-by: Jacob Emery <[email protected]>
Signed-off-by: Jacob Emery <[email protected]>
Signed-off-by: Jacob Emery <[email protected]>
Signed-off-by: Jacob Emery <[email protected]>
Signed-off-by: Jacob Emery <[email protected]>
Signed-off-by: Jacob Emery <[email protected]>
Signed-off-by: Jacob Emery <[email protected]>
Signed-off-by: Jacob Emery <[email protected]>
Signed-off-by: Jacob Emery <[email protected]>
Signed-off-by: Jacob Emery <[email protected]>
Signed-off-by: Jacob Emery <[email protected]>
… setup. Signed-off-by: Jacob Emery <[email protected]>
Signed-off-by: Jacob Emery <[email protected]>
Signed-off-by: Jacob Emery <[email protected]>
Signed-off-by: Jacob Emery <[email protected]>
Signed-off-by: Jacob Emery <[email protected]>
Signed-off-by: Jacob Emery <[email protected]>
…ng was complete before moving to compute nodes Signed-off-by: Jacob Emery <[email protected]>
…ng was complete before moving to compute nodes Signed-off-by: Jacob Emery <[email protected]>
Signed-off-by: Jacob Emery <[email protected]>
…oks (IBM#190) Added support for non root user to run hypershift playbooks - Updated playbooks to allow users with sudo privileges to run the hypershift playbooks. - Added change to wait for MCE to be available after creating AgentServiceConfig. Updated documentation for the same --------- Signed-off-by: [email protected] <[email protected]>
Changed ssh key path - Hypershift - Changed the path for ssh key on local host - Removed space while creating HCP which is causing issue while using different basedomian --------- Signed-off-by: [email protected] <[email protected]>
…BM#193) This patch detects the required RHCOS images to install a compute node. Signed-off-by: Klaus Smolin <[email protected]>
Changed port for httpd configuration - Earlier we used port 443 and 8080 for httpd , but we have conflict with port 443 while configuring HAProxy in later stages. - So changed the port from 443 to 8443 --------- Signed-off-by: [email protected] <[email protected]>
Update mkdocs.yaml file to include run-the-playbooks-for-hypershift.md, and to remove CHANGELOG file as it has been replaced with semantic-release. Signed-off-by: Jacob Emery <[email protected]>
This adds a new workflow to GitHub Actions. The action deploys an updated version of the documentation to GitHub Pages. It is triggered when changes are pushed to 'mkdocs.yaml' or anything under the 'docs' folder on the 'main' branch. This is necessary to make the docs up-to-date with our code, without manual intervention. Tested on my fork, although it required some tweaking there to adjust it for testing purposes, so it might take some troubleshooting here in the upstream. Signed-off-by: Jacob Emery <[email protected]>
Fix for issue IBM#188 (root user suport). In addition set 0 for ip_forward var as default because macvtap is default network setting. In addition add var for subscription management. --------- Signed-off-by: DAMISETTI-VEERABHADRARAO <[email protected]> Signed-off-by: [email protected] <[email protected]> Signed-off-by: Amadeuds Podvratnik <[email protected]> Signed-off-by: Klaus Smolin <[email protected]> Signed-off-by: Jacob Emery <[email protected]> Co-authored-by: veera-damisetti <[email protected]> Co-authored-by: Jacob Emery <[email protected]> Co-authored-by: Klaus Smolin <[email protected]> Co-authored-by: Klaus Smolin <[email protected]>
Hotfix to IBM#196 that automates GitHub Pages deployments. Looks like the workflow failed in error because it didn't have the most recent version of the gh-pages branch. This PR will hopefully fix that issue. Signed-off-by: Jacob Emery <[email protected]>
|
@jacobemery I went through the changes and have some comments:
|
Signed-off-by: Jacob Emery [email protected]
Improve error handling. Signed-off-by: Klaus Smolin <[email protected]>
Signed-off-by: Klaus Smolin <[email protected]>
- Added ClusterImageSet creation for nightly build image Signed-off-by: [email protected] <[email protected]>
Add support to create a aarch64 (arm64) compute node using create_compute_node.yaml playbook. Signed-off-by: Klaus Smolin <[email protected]>
In order to test docs deployment GH action, add a manual deployment option.
Signed-off-by: Klaus Smolin <[email protected]>
AmadeusPodvratnik
requested changes
Oct 10, 2023
There was a problem hiding this comment.
Thx @jacobemery for the PR. I tested it and have following comments:
- due to the fact that a file_server entry in the hosts file is needed, this should be documented.
- Make it sense to automate this step in case an user would like to have it "all together". E.g. if a user would like to have it all self contained than this step can be integrated into a more general setup playbook.
- For macvtap network mode any other VM can be used if the LPAR has access to. Is this something you would like to mention?
There are several open issues related to DNS. DNS setup needs to be verified. We ignore some DNS check results for now, because of issue 166, 182. Signed-off-by: Klaus Smolin <[email protected]>
Signed-off-by: Klaus Smolin <[email protected]>
The creation of VM's requires more time on low performance systems. Signed-off-by: Klaus Smolin <[email protected]>
|
Needs rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue 'Create optional playbook to setup file server' #103.
Add a playbook to automatically setup the file server. Based on feedback from users, the file server's setup causes a lot of confusion.
This playbook is not part of the official install path, but meant to be a helpful additional resource if needed. It would serve as an "executable documentation" for setting up the file server. Either this works as-is for some user's needs; or for those that it doesn't meet their needs, it at least lays out precisely what must be done.
Also adds accompanying documentation in prerequisites and run_the_playbooks pages.