Update docker base image, Django and Wagtail #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bjwebb
force-pushed
the
feature/update-django-wagtail
branch
from
76f8a79
to
38fcd2c
Compare
simon-20
previously approved these changes
Aug 15, 2024
Bjwebb
force-pushed
the
feature/update-django-wagtail
branch
from
38fcd2c
to
f666484
Compare
Bjwebb
force-pushed
the
feature/update-django-wagtail
branch
from
a522c40
to
c945ed6
Compare
Bjwebb
force-pushed
the
feature/update-django-wagtail
branch
from
c945ed6
to
d9e8b14
Compare
odscjames
reviewed
Sep 10, 2024
odscjames
reviewed
Sep 10, 2024
odscjames
reviewed
Sep 10, 2024
|
I don't quite understand dev_public, it seems to be used for testing? Is it used for anything else? |
Bjwebb
force-pushed
the
feature/update-django-wagtail
branch
from
d9e8b14
to
1dd695a
Compare
|
dev_public is for using on https://dev.iatistandard.org/en/. As we want some dev settings, but it's not really secure to set Debug=True as the main dev settings do. |
This now casuses an error. This is maybe not the ideal way to fix this, but I expect this to be overhauled when we adopt the new design system: https://github.com/IATI/design-system/
Updating pylint was necessary to update flake8 to the latest version, as they share dependencies. For now, pylint is disabled, because it now produces far too many error messages. We should selectively renable it for new files we work on.
(and there's currently none in the datbase)
Bjwebb
force-pushed
the
feature/update-django-wagtail
branch
from
1dd695a
to
b2d5df7
Compare
odscjames
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.