Filter/square brackets #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
=====================================
Coverage 95.0% 95.0%
=====================================
Files 64 63 -1
Lines 6134 6158 +24
=====================================
+ Hits 5828 5851 +23
- Misses 306 307 +1 ☔ View full report in Codecov by Sentry. |
phackstock
approved these changes
Apr 19, 2024
pyam/str.py
Outdated
| @@ -4,6 +4,8 @@ | |||
| import pandas as pd | |||
| from pandas.api.types import is_list_like | |||
|
|
|||
| REGEXP_CHARACTERS = r".+()[]{}|$" | |||
There was a problem hiding this comment.
Not that I'd ever seen it but we can add the caret symbol as well ^, especially since you have the dollar sign:
Suggested change
| REGEXP_CHARACTERS = r".+()[]{}|$" | |
| REGEXP_CHARACTERS = r".+()[]{}|$^" |
There was a problem hiding this comment.
Thanks for this comment - went through the list of regex-characters at https://docs.python.org/3/library/re.html and also added ?...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please confirm that this PR has done the following:
Documentation AddedName of contributors Added to AUTHORS.rstDescription in RELEASE_NOTES.md AddedDescription of PR
This PR fixes an issue where filtering by a string with square brackets is interpreted as regexp and doesn't work as expected.