-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facilitate region-aggregation with inconsistent model scenario region time #792
Facilitate region-aggregation with inconsistent model scenario region time #792
Conversation
Codecov Report
@@ Coverage Diff @@
## main #792 +/- ##
=======================================
+ Coverage 94.5% 94.7% +0.1%
=======================================
Files 62 62
Lines 5966 5996 +30
=======================================
+ Hits 5643 5681 +38
+ Misses 323 315 -8
|
I vaguely recall that @orichters expressed interest in a more flexible handling of the region-aggregation-with-weights...? |
I do not 😃. Maybe @Renato-Rodrigues, if it was someone from the REMIND team? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Can #754 be closed then since you're no longer raising an issue if weights are a superset of the data?
Please confirm that this PR has done the following:
Documentation AddedName of contributors Added to AUTHORS.rstDescription of PR
This PR improves the handling of region-aggregation when variables and weights have an inconsistent index.
Now, if weights are missing, a ValueError is raised with (the head of) a list of missing rows. If variable data is missing, a warning is written to the log with (the head of) a list of missing rows.
closes #558