Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EER support in Dose Analysis #852

Draft
wants to merge 4 commits into
base: devel
Choose a base branch
from
Draft

Conversation

Ratolon
Copy link
Contributor

@Ratolon Ratolon commented Dec 11, 2024

Xmipp3 Dose Analysis fails when using EER. This is against our latest effort for EER support in Xmipp. Thus, I am implementing EER support for dose analysis protocol.

Bsos,
Mikel.

@Ratolon Ratolon added the bug Something isn't working label Dec 11, 2024
@Ratolon Ratolon self-assigned this Dec 11, 2024
@albertmena
Copy link
Collaborator

Related: I2PC/xmipp#939

@Ratolon Ratolon marked this pull request as ready for review December 11, 2024 15:11
@Ratolon Ratolon marked this pull request as draft December 11, 2024 15:33
@Ratolon
Copy link
Contributor Author

Ratolon commented Dec 11, 2024

Okay seems to be working but it is still very slow. The slowness will be addressed for next release

@Ratolon Ratolon marked this pull request as ready for review December 11, 2024 16:27
Copy link
Collaborator

@albertmena albertmena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The protocol never ends (2h) with EER files, running 8 files from https://www.ebi.ac.uk/empiar/EMPIAR-11487/

Copy link
Collaborator

@albertmena albertmena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The protocol never ends (2h) with EER files, running 8 files from https://www.ebi.ac.uk/empiar/EMPIAR-11487/

@albertmena albertmena self-requested a review December 12, 2024 08:41
@Ratolon
Copy link
Contributor Author

Ratolon commented Dec 12, 2024

This protocol clearly needs more work so let's keep it a draft

@Ratolon Ratolon marked this pull request as draft December 12, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants