-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New protocol: Movie alignment consensus #771
Conversation
… change the way to access the inputMicrographs
# Conflicts: # xmipp3/protocols/__init__.py # xmipp3/viewers/__init__.py
Quality Gate failedFailed conditions 6.4% Duplication on New Code (required ≤ 3%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test fails
raise Exception("All movies failed, didn't create outputMicrographs."
Exception: All movies failed, didn't create outputMicrographs.Please review movie processing steps above.
Protocol failed: All movies failed, didn't create outputMicrographs.Please review movie processing steps above.
I checked again and ran it with all my repositories updated, and the two tests passed without any problem. @oierlauzi, could you please check where the test is failing? Maybe it has something to do with an old version of the Scipion repositories. |
Now, it works for me |
class XmippProtConsensusMovieAlignment(ProtAlignMovies, Protocol): | ||
""" | ||
Protocol to estimate the agreement between different movie alignment | ||
algorithms in the Global Shifts). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete parenthesis
|
||
form.addParam('minConsCorrelation', params.FloatParam, default=-1, | ||
label='Minimum consensus shifts correlation', | ||
help="Minimum value for the consensus correlations between shifts trajectories." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the meaning of -1, is there any maximum value? Minimum?, please explain it
Quality Gate failedFailed conditions |
New protocol for the comparison of two global alignments