Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New protocol: Movie alignment consensus #771

Merged
merged 25 commits into from
May 14, 2024
Merged

Conversation

danielmarchan3
Copy link
Contributor

New protocol for the comparison of two global alignments

@danielmarchan3 danielmarchan3 added the enhancement New feature or request label Feb 6, 2024
@danielmarchan3 danielmarchan3 self-assigned this Feb 6, 2024
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

6.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Collaborator

@albertmena albertmena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test fails

    raise Exception("All movies failed, didn't create outputMicrographs."
Exception: All movies failed, didn't create outputMicrographs.Please review movie processing steps above.
Protocol failed: All movies failed, didn't create outputMicrographs.Please review movie processing steps above.

@danielmarchan3
Copy link
Contributor Author

danielmarchan3 commented Feb 29, 2024

I checked again and ran it with all my repositories updated, and the two tests passed without any problem. @oierlauzi, could you please check where the test is failing? Maybe it has something to do with an old version of the Scipion repositories.

@albertmena
Copy link
Collaborator

I checked again and ran it with all my repositories updated, and the two tests passed without any problem. @oierlauzi, could you please check where the test is failing? Maybe it has something to do with an old version of the Scipion repositories.

Now, it works for me

class XmippProtConsensusMovieAlignment(ProtAlignMovies, Protocol):
"""
Protocol to estimate the agreement between different movie alignment
algorithms in the Global Shifts).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete parenthesis


form.addParam('minConsCorrelation', params.FloatParam, default=-1,
label='Minimum consensus shifts correlation',
help="Minimum value for the consensus correlations between shifts trajectories."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the meaning of -1, is there any maximum value? Minimum?, please explain it

@danielmarchan3 danielmarchan3 requested a review from albertmena May 13, 2024 14:26
Copy link

sonarqubecloud bot commented May 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@albertmena albertmena merged commit 4dce23a into devel May 14, 2024
1 of 2 checks passed
@albertmena albertmena deleted the dmt_consensus_alignment branch May 14, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants