SNS - ADC Mux #41
Open
SNS - ADC Mux #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbeechey
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Looks good, would be good to have a function for just reading a single channel of the mux. To do so it'd be best to have the channel addresses as an enum, so that'll require modification to the read_data function too.
Edit: actually, it would be really good if we had something like AdcMuxChannel which implemented the HypedAdc trait from PR #41. That would mean we don't need to care whether an ADC sensor is plugged into the ADC on the ST board or into the mux, the sensor can just use anything that implements HypedAdc. It would need to take in a shared I2C instance (using Mutex like in the I2C mux PR #14), the mux address and the channel address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.