SNS - Optical Flow #32
Conversation
There was a problem hiding this comment.
Move to lib/sensors/src/optical_flow.rs (you'll need to add it to lib/sensors/src/lib.rs too
|
|
||
|
|
||
| // Make main function with flexible error handling | ||
| pub fn main() -> Result<(), Box<dyn std::error::Error>> { |
There was a problem hiding this comment.
This function won't live here, it'll be in one of the board/{board_name}/tasks folders as a task. Have a look at boards/stm32l476rg/src/tasks/temperature.rs as an example. (Just copy this code into a structure similar to that for now)
| impl<SPI> PMW3901<SPI> | ||
| where | ||
| SPI: HypedSpi, | ||
| { |
There was a problem hiding this comment.
| impl<SPI> PMW3901<SPI> | |
| where | |
| SPI: HypedSpi, | |
| { | |
| impl<SPI: HypedSpi> PMW3901<SPI> |
You should be able to do something shorter like this instead
| const TIMEOUT: Duration = Duration::from_secs(5); | ||
|
|
||
|
|
||
| pub struct PMW3901<SPI> { |
There was a problem hiding this comment.
| pub struct PMW3901<SPI> { | |
| pub struct PMW3901<SPI: HypedSpi> { |
It's also standard to have single uppercase characters as type parameters, like T. But I don't mind SPI for now
There was a problem hiding this comment.
Probs better to call this OpticalFlow also
| } | ||
|
|
||
| // **ATTEMPTED PYTHON IMPLEMENTATION OF get_motion** | ||
| pub fn get_motion(&mut self) -> Result<(i16, i16), &'static str>{ |
There was a problem hiding this comment.
You'll want to define an error enum type like OpticalFlowError instead of returning a string here. Have a look at TemperatureError as an example (you'll probably want to have an enum variant for SpiError for example
No description provided.