Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to debug the MSW uncaught http request error in CircleCi builds #1693

Closed

Conversation

KevinTriplett
Copy link
Contributor

This is my first attempt to debug the strange MSW error referenced in #1684 -- no review requested at this time, since the error only happens on PR commits, this is the only way to debut it.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 47.30%. Comparing base (d9614ff) to head (5a5981b).

Files Patch % Lines
src/util/testing/mockGraphqlServer.js 14.28% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1693      +/-   ##
==========================================
- Coverage   47.33%   47.30%   -0.03%     
==========================================
  Files         581      582       +1     
  Lines       13934    13951      +17     
  Branches     4023     4023              
==========================================
+ Hits         6595     6600       +5     
- Misses       7339     7351      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomasgwatson
Copy link
Collaborator

If you scroll down to:

src/routes/AuthLayoutRouter/AuthLayoutRouter.test.js

In this PR, you can see what I added to stop an iteration of this warning

Basically there is an unmocked request happening somewhere and its a bit of a hunt to find it, if the warning persists

@KevinTriplett
Copy link
Contributor Author

KevinTriplett commented Aug 25, 2024

Basically there is an unmocked request happening somewhere and its a bit of a hunt to find it, if the warning persists

What's confusing me is that it's caught on CI but not on my dev machine -- do you get this warning in your environment @thomasgwatson?

@tibetsprague
Copy link
Contributor

so we should remove this PR?

@KevinTriplett
Copy link
Contributor Author

We can ... I haven't had time to continue it, I'm beginning to think it's a problem with versions of libraries that we're using. That's a bigger issue. I'll close it now and we can decide to re-open if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants