(feat): [types] require credentials when initializing HumeClient #190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes two changes to the HumeClient defined In
wrapper
(i.e. it's controlled manually, not fern-generated).Remove expressionMeasurement override I removed the redefinition ofnever mind, I was just confused.expressionMeasurement
and_expressionMeasurement
. This is identical to what is in the parent FernClient class, so seemed needless to me.HumeClient.Options
type to always require eitherapiKey
oraccessToken
. We want to prevent users from initializing the client without credentials because this will result in errors further downstream when they attempt to make requests / open connections.Union of intersection can be confusing, I tested things out here.