Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OPTIC-1229: Remove if getattr(settings, 'CLOUD_INSTANCE', False) #6530

Conversation

luarmr
Copy link
Contributor

@luarmr luarmr commented Oct 16, 2024

This code is being tested enough and we want to bring in to onprem customers and open source.

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 137ceca
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/671003994f9f52000845d69d

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 137ceca
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67100399d6f064000820c8a7

@github-actions github-actions bot added the fix label Oct 16, 2024
@luarmr luarmr force-pushed the fb-optic-1229/remove-if-getattrsettings-cloudinstance-false-check-for-isdelete branch from 7ce28e4 to 47e703f Compare October 16, 2024 18:03
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.67%. Comparing base (82b9e3c) to head (137ceca).
Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
label_studio/users/serializers.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6530   +/-   ##
========================================
  Coverage    76.67%   76.67%           
========================================
  Files          169      169           
  Lines        13778    13773    -5     
========================================
- Hits         10564    10561    -3     
+ Misses        3214     3212    -2     
Flag Coverage Δ
pytests 76.67% <60.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luarmr luarmr merged commit 9627702 into develop Oct 17, 2024
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants