Merge pull request #64 from adidahiya/options-content-function

(bugfix) clear content element when setting from options.content function that returns an Element
HubSpot · Apr 21, 2015 · 0531e75 · 0531e75
2 parents 41e3e66 + cf741cd
commit 0531e75
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 1 deletion.
diff --git a/coffee/drop.coffee b/coffee/drop.coffee
@@ -123,6 +123,7 @@ createContext = (options={}) ->
           if typeof contentElementOrHTML is 'string'
             @content.innerHTML = contentElementOrHTML
           else if typeof contentElementOrHTML is 'object'
+            @content.innerHTML = ""
             @content.appendChild(contentElementOrHTML)
           else
             throw new Error 'Drop Error: Content function should return a string or HTMLElement.'

diff --git a/drop.js b/drop.js
@@ -1604,6 +1604,7 @@ return this.Tether;
             if (typeof contentElementOrHTML === 'string') {
               return _this.content.innerHTML = contentElementOrHTML;
             } else if (typeof contentElementOrHTML === 'object') {
+              _this.content.innerHTML = "";
               return _this.content.appendChild(contentElementOrHTML);
             } else {
               throw new Error('Drop Error: Content function should return a string or HTMLElement.');