Skip to content
This repository has been archived by the owner on Sep 17, 2019. It is now read-only.

Fix issue: Asciidoc Style issues #193 #198

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

lametaweb
Copy link

Icons are now shown in admonitions for ichi theme.

@anthonny
Copy link
Member

Hi @lametaweb!

I did not forget you, i'll make a review asap but atm i'm a really busy
Thank you for this PR

@lametaweb
Copy link
Author

You are welcome. Time is a limited resource! I wait till then. Thank you very much.

@lametaweb lametaweb mentioned this pull request May 2, 2015
@lametaweb
Copy link
Author

PR updated. Cheers.

@lametaweb lametaweb mentioned this pull request May 3, 2015
@anthonny
Copy link
Member

anthonny commented Jul 2, 2015

Hi @lametaweb
Thank you so much for your work!

Like i said in the issue, adding the css in each themes is a good workaround, but i'm not sure that is the best solution

But i have an idea, what do you think about make something in the javascript code ?

I explain.
To add highlight.js in all theme, i have done this :

head.push(utils.stylesheetTemplate({
    source: '//cdnjs.cloudflare.com/ajax/libs/highlight.js/8.4/styles/default.min.css',
    version: ''
}));

We could try the same thing for the asciidoctor.css, wdyt?

@lametaweb
Copy link
Author

Hi @anthonny I think is a good non invasive solution!
It wouldn't be necessary to include these two css files: asciidoctor.css plus font-awesome.css?
Best regards.

Ardemius added a commit to Ardemius/ardemius.github.io that referenced this pull request Oct 31, 2015
fix for the missing admonition icons in ichi theme : see issues HubPress#193 and HubPress#198
HubPress#193
HubPress#198
Ardemius added a commit to Ardemius/ardemius.github.io that referenced this pull request Oct 31, 2015
@jaredmorgs
Copy link
Contributor

Ready to merge, @anthonny ?

@lametaweb
Copy link
Author

OK, thanks!!

2016-04-25 12:00 GMT+02:00 Jared Morgan [email protected]:

Ready to merge, @anthonny https://github.com/anthonny ?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#198 (comment)

@jaredmorgs
Copy link
Contributor

I wonder if we can cherry pick some fixes out of this one @anthonny so @lametaweb doesn't lose his contribution.

@jaredmorgs jaredmorgs modified the milestone: Release 8 Mar 2, 2017
@anthonny
Copy link
Member

anthonny commented Mar 2, 2017

@jaredmorgs i agree with you when you say that we do not loose the contribution of @lametaweb

I have to think about the impact of the asciidoctor.css on themes. What i mean is, if you consider this lines from the asciidoctor.css file:
https://github.com/HubPress/hubpress.io/pull/198/files#diff-4dc6b9ca4e2bb6b523ae765fa201e6e8R22

https://github.com/HubPress/hubpress.io/pull/198/files#diff-4dc6b9ca4e2bb6b523ae765fa201e6e8R134

how can we be sure that il will not explode the main theme.
I'm really sorry @lametaweb for having take so much time to answer, i will understand if you are not interested by this subject anymore.

I have to take more time of this problem

@jaredmorgs
Copy link
Contributor

We'll leave this one here as a reminder more than anything. It might be worthwhile putting this into a milestone that only deals with theming so we can hit all the theming issues in one pass.

I think I'll set that one up now.

@jaredmorgs jaredmorgs modified the milestones: Theming, Release 8 Mar 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants