Skip to content

Commit

Permalink
Updates code base according to pexpect v4.9
Browse files Browse the repository at this point in the history
  • Loading branch information
HorlogeSkynet committed Sep 4, 2024
1 parent 06b8bce commit 5890212
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ Open your command palette and type in `SSHubl` to select `Connect to server`. On

### Why can I connect to new hosts without accepting their fingerprint ?

> `pexpect` package is [known to always accept remotes' public key](https://github.com/pexpect/pexpect/blob/4.8.0/pexpect/pxssh.py#L411-L414), and it isn't configurable.
> `pexpect` package is [known to always accept remotes' public key](https://github.com/pexpect/pexpect/blob/4.9/pexpect/pxssh.py#L411-L414), and it isn't configurable.
### How is "SSHubl" pronounced ?

Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
pexpect~=4.8.0
pexpect~=4.9.0

pylint~=3.2.7
pylint-secure-coding-standard~=1.5.1
Expand Down
4 changes: 0 additions & 4 deletions sshubl/ssh_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,6 @@ def ssh_connect(
}
)

# pexpect v4.8 is currently packaged for Sublime Text so it still specifies old
# `RSAAuthentication` option
ssh.SSH_OPTS = "-o PubkeyAuthentication=no"

# if a password has been given, force password authentication
if password is not None:
ssh.force_password = True
Expand Down

0 comments on commit 5890212

Please sign in to comment.