Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in SVG path command T #1443 #1444

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ralfstx
Copy link

@ralfstx ralfstx commented Apr 23, 2023

The control point (px, py) is already updated in the else branch above (L271). It is then updated once again which causes bug #1443.

This commit removes these duplicated lines which fixes the bug.

What?

Why?

How?

Testing?

New Dependencies?

Screenshots

Suggested Reading?

Anything Else?

Checklist

  • I read CONTRIBUTING.md.
  • I read MAINTAINERSHIP.md#pull-requests.
  • I added/updated unit tests for my changes.
  • I added/updated integration tests for my changes.
  • I ran the integration tests.
  • I tested my changes in Node, Deno, and the browser.
  • I viewed documents produced with my changes in Adobe Acrobat, Foxit Reader, Firefox, and Chrome.
  • I added/updated doc comments for any new/modified public APIs.
  • My changes work for both new and existing PDF files.
  • I ran the linter on my changes.

The control point (`px`, `py`) is already updated in the else branch
above (L271). It is then updated once again which causes bug Hopding#1443.

This commit removes these duplicated lines which fixes the bug.
@Sharcoux
Copy link

Would you mind checking if this bug seems necessary in @cantoo/pdf-lib ? Waiting for Hopding to have the time to keep up with the contributions here, we made our fork that we try to maintain there.

@ralfstx
Copy link
Author

ralfstx commented Oct 2, 2023

@Sharcoux Here you go: cantoo-scribe#30

@laszlo1337
Copy link

Does this have chance to be fixed?

@Sharcoux
Copy link

This has been released in @cantoo/pdf-lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants