Make lineCap prop optional (#460)

* Make lineCap prop optional * Update tests * Cleanup
Hopding · May 25, 2020 · 3256473 · 3256473
1 parent 216d9e7
commit 3256473
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 6 deletions.
diff --git a/apps/deno/tests/test3.ts b/apps/deno/tests/test3.ts
@@ -72,13 +72,19 @@ export default async (assets: Assets) => {
     end: { x: 30 + lastPageTextWidth, y: 205 },
     color: hotPink,
     thickness: 5,
-    lineCap: LineCapStyle.Round,
   });
   page2.drawImage(cmykImage, {
     ...cmykDims,
     x: 30,
     y: 30,
   });
+  page2.drawLine({
+    start: { x: 30, y: 240 },
+    end: { x: 30 + lastPageTextWidth, y: 240 },
+    color: hotPink,
+    thickness: 5,
+    lineCap: LineCapStyle.Round,
+  });
 
   console.log('Title:', pdfDoc.getTitle());
   console.log('Author:', pdfDoc.getAuthor());

diff --git a/apps/node/tests/test3.ts b/apps/node/tests/test3.ts
@@ -71,13 +71,19 @@ export default async (assets: Assets) => {
     end: { x: 30 + lastPageTextWidth, y: 205 },
     color: hotPink,
     thickness: 5,
-    lineCap: LineCapStyle.Round,
   });
   page2.drawImage(cmykImage, {
     ...cmykDims,
     x: 30,
     y: 30,
   });
+  page2.drawLine({
+    start: { x: 30, y: 240 },
+    end: { x: 30 + lastPageTextWidth, y: 240 },
+    color: hotPink,
+    thickness: 5,
+    lineCap: LineCapStyle.Round,
+  });
 
   console.log('Title:', pdfDoc.getTitle());
   console.log('Author:', pdfDoc.getAuthor());

diff --git a/apps/rn/src/tests/test3.js b/apps/rn/src/tests/test3.js
@@ -72,13 +72,19 @@ export default async () => {
     end: { x: 30 + lastPageTextWidth, y: 205 },
     color: hotPink,
     thickness: 5,
-    lineCap: LineCapStyle.Round,
   });
   page2.drawImage(cmykImage, {
     ...cmykDims,
     x: 30,
     y: 30,
   });
+  page2.drawLine({
+    start: { x: 30, y: 240 },
+    end: { x: 30 + lastPageTextWidth, y: 240 },
+    color: hotPink,
+    thickness: 5,
+    lineCap: LineCapStyle.Round,
+  });
 
   console.log('Title:', pdfDoc.getTitle());
   console.log('Author:', pdfDoc.getAuthor());

diff --git a/apps/web/test3.html b/apps/web/test3.html
@@ -120,13 +120,19 @@
         end: { x: 30 + lastPageTextWidth, y: 205 },
         color: hotPink,
         thickness: 5,
-        lineCap: LineCapStyle.Round,
       });
       page2.drawImage(cmykImage, {
         ...cmykDims,
         x: 30,
         y: 30,
       });
+      page2.drawLine({
+        start: { x: 30, y: 240 },
+        end: { x: 30 + lastPageTextWidth, y: 240 },
+        color: hotPink,
+        thickness: 5,
+        lineCap: LineCapStyle.Round,
+      });
 
       console.log('Title:', pdfDoc.getTitle());
       console.log('Author:', pdfDoc.getAuthor());

diff --git a/src/api/PDFPageOptions.ts b/src/api/PDFPageOptions.ts
@@ -55,9 +55,9 @@ export interface PDFPageDrawRectangleOptions {
 export interface PDFPageDrawLineOptions {
   start: { x: number; y: number };
   end: { x: number; y: number };
-  lineCap: LineCapStyle | undefined;
   thickness?: number;
   color?: Color;
+  lineCap?: LineCapStyle;
 }
 
 export interface PDFPageDrawSquareOptions {

diff --git a/src/api/operations.ts b/src/api/operations.ts
@@ -135,8 +135,8 @@ export const drawLine = (options: {
   start: { x: number | PDFNumber; y: number | PDFNumber };
   end: { x: number | PDFNumber; y: number | PDFNumber };
   thickness: number | PDFNumber;
-  lineCap: LineCapStyle | undefined;
   color: Color | undefined;
+  lineCap?: LineCapStyle;
 }) =>
   [
     pushGraphicsState(),