Merge branch 'master' into implement-114

.github/workflows/image-minimizer.js

@@ -34,7 +34,7 @@ module.exports = async ({github, context}) => {
 
     // Regex for finding images (simple variant) ![ALT_TEXT](https://*.githubusercontent.com/<number>/<variousHexStringsAnd->.<fileExtension>)
     const REGEX_USER_CONTENT_IMAGE_LOOKUP = /\!\[(.*)\]\((https:\/\/[-a-z0-9]+\.githubusercontent\.com\/\d+\/[-0-9a-f]{32,512}\.(jpg|gif|png))\)/gm;
-    const REGEX_ASSETS_IMAGE_LOCKUP = /\!\[(.*)\]\((https:\/\/github\.com\/[-\w\d]+\/[-\w\d]+\/assets\/\d+\/[\-0-9a-f]{32,512})\)/gm;
+    const REGEX_ASSETS_IMAGE_LOCKUP = /\!\[(.*)\]\((https:\/\/github\.com\/user-attachments\/assets\/[\-0-9a-f]{36,})\)/gm;
 
     // Check if we found something
     let foundSimpleImages = REGEX_USER_CONTENT_IMAGE_LOOKUP.test(initialBody)

.github/workflows/no-response.yml

@@ -21,5 +21,5 @@ jobs:
         with:
           token: ${{ github.token }}
           # Number of days of inactivity before an issue is closed for lack of response.
-          daysUntilClose: 30
+          daysUntilClose: 14
           responseRequiredLabel: waiting for author

CHANGELOG.md

@@ -1,24 +1,33 @@
 Changelog
 ==========
 
+Version 1.3.0 *(2024-10-30)*
+----------------------------
+
+* Fixed issue with contacts not displaying on Android 14 and above
+* Replaced checkboxes with switches
+* Removed support for Android 7 and older versions
+* Other minor bug fixes and improvements
+* Added more translations
+
 Version 1.2.0 *(2024-05-08)*
 ----------------------------
 
-- Fixed an issue where call history wasn't refreshing (https://github.com/FossifyOrg/Phone/issues/146).
-- Fixed a problem where search items would disappear (https://github.com/FossifyOrg/Phone/issues/98).
-- Fixed UI freeze that happened when loading call history.
-- Fixed a bug that caused search not to find older call logs (https://github.com/FossifyOrg/Phone/issues/97).
-- Fixed a crash that occurred when using the dialpad quick callback feature.
-- Missed call notifications are now automatically dismissed when you view your call history (https://github.com/FossifyOrg/Phone/issues/88).
-- Moved some actions back into the popup menu to reduce visual clutter (https://github.com/FossifyOrg/General-Discussion/issues/67).
-- Updated menu design for better UI/UX.
-- Disabled call action buttons after a call ends for better UI/UX (https://github.com/FossifyOrg/Phone/issues/181).
-- Grouped call history entries by date (https://github.com/FossifyOrg/Phone/issues/96).
-- Added an option to format phone numbers in the call log (https://github.com/FossifyOrg/Contacts/issues/15).
-- Always show the date in the call details dialog (https://github.com/FossifyOrg/Phone/issues/133).
-- Updated call direction icons and colors in the call history for better clarity (https://github.com/FossifyOrg/Phone/issues/81).
-- Restructured the in-call UI to be more responsive to different screen sizes (https://github.com/FossifyOrg/Phone/issues/147).
-- Added some translations.
+* Fixed an issue where call history wasn't refreshing (https://github.com/FossifyOrg/Phone/issues/146).
+* Fixed a problem where search items would disappear (https://github.com/FossifyOrg/Phone/issues/98).
+* Fixed UI freeze that happened when loading call history.
+* Fixed a bug that caused search not to find older call logs (https://github.com/FossifyOrg/Phone/issues/97).
+* Fixed a crash that occurred when using the dialpad quick callback feature.
+* Missed call notifications are now automatically dismissed when you view your call history (https://github.com/FossifyOrg/Phone/issues/88).
+* Moved some actions back into the popup menu to reduce visual clutter (https://github.com/FossifyOrg/General-Discussion/issues/67).
+* Updated menu design for better UI/UX.
+* Disabled call action buttons after a call ends for better UI/UX (https://github.com/FossifyOrg/Phone/issues/181).
+* Grouped call history entries by date (https://github.com/FossifyOrg/Phone/issues/96).
+* Added an option to format phone numbers in the call log (https://github.com/FossifyOrg/Contacts/issues/15).
+* Always show the date in the call details dialog (https://github.com/FossifyOrg/Phone/issues/133).
+* Updated call direction icons and colors in the call history for better clarity (https://github.com/FossifyOrg/Phone/issues/81).
+* Restructured the in-call UI to be more responsive to different screen sizes (https://github.com/FossifyOrg/Phone/issues/147).
+* Added some translations.
 
 Version 1.1.1 *(2024-03-21)*
 ----------------------------

README.md

@@ -3,7 +3,7 @@
 
 <a href='https://play.google.com/store/apps/details?id=org.fossify.phone'><img alt='Get it on Google Play' src='https://play.google.com/intl/en_us/badges/static/images/badges/en_badge_web_generic.png' height=80/></a> <a href="https://f-droid.org/packages/org.fossify.phone/"><img src="https://fdroid.gitlab.io/artwork/badge/get-it-on-en.svg" alt="Get it on F-Droid" height=80/></a> <a href="https://apt.izzysoft.de/fdroid/index/apk/org.fossify.phone"><img src="https://gitlab.com/IzzyOnDroid/repo/-/raw/master/assets/IzzyOnDroid.png" alt="Get it on IzzyOnDroid" height=80/></a>
 
-Empower your calls, safeguard your data. Fossify Phone redefines the mobile app experience with unmatched privacy and efficiency. Free from ads and intrusive permissions, it's designed for seamless and secure everyday communication.
+Empower your calls, and safeguard your data. Fossify Phone redefines the mobile app experience with unmatched privacy and efficiency. Free from ads and intrusive permissions, it's designed for seamless and secure everyday communication.
 
 📱 **YOUR PRIVACY, OUR PRIORITY:**  
 Welcome to the Fossify Phone App, where your digital privacy is paramount. Switch to a mobile experience that respects your data, ensuring your personal information remains secure and private.

app/build.gradle.kts

@@ -49,6 +49,7 @@ android {
         }
         release {
             isMinifyEnabled = true
+            isShrinkResources = true
             proguardFiles(
                 getDefaultProguardFile("proguard-android-optimize.txt"),
                 "proguard-rules.pro"
@@ -92,6 +93,13 @@ android {
         warningsAsErrors = true
         baseline = file("lint-baseline.xml")
     }
+
+    bundle {
+        language {
+            @Suppress("UnstableApiUsage")
+            enableSplit = false
+        }
+    }
 }
 
 detekt {

app/src/main/AndroidManifest.xml

@@ -33,10 +33,15 @@
     <queries>
         <package android:name="org.fossify.contacts.debug" />
         <package android:name="org.fossify.contacts" />
+
+        <!-- Required for loading contact accounts -->
+        <intent>
+            <action android:name="android.accounts.AccountAuthenticator" />
+        </intent>
     </queries>
 
     <application
-        android:name="org.fossify.phone.App"
+        android:name="org.fossify.commons.FossifyApp"
         android:allowBackup="true"
         android:appCategory="productivity"
         android:icon="@mipmap/ic_launcher"

app/src/main/kotlin/org/fossify/phone/activities/CallActivity.kt

@@ -82,7 +82,7 @@ class CallActivity : SimpleActivity() {
         updateCallContactInfo(CallManager.getPrimaryCall())
     }
 
-    override fun onNewIntent(intent: Intent?) {
+    override fun onNewIntent(intent: Intent) {
         super.onNewIntent(intent)
         updateState()
     }
@@ -92,7 +92,7 @@ class CallActivity : SimpleActivity() {
         updateState()
         updateNavigationBarColor(getProperBackgroundColor())
 
-        if (config.isUsingSystemTheme) {
+        if (isDynamicTheme()) {
             updateStatusbarColor(getProperBackgroundColor())
         }
     }
@@ -219,7 +219,7 @@ class CallActivity : SimpleActivity() {
         }
 
         dialpadWrapper.setBackgroundColor(
-            if (isUsingSystemDarkTheme()) {
+            if (isSystemInDarkMode()) {
                 getProperBackgroundColor().lightenColor(2)
             } else {
                 getProperBackgroundColor()

app/src/main/kotlin/org/fossify/phone/activities/SimpleActivity.kt

@@ -27,4 +27,6 @@ open class SimpleActivity : BaseSimpleActivity() {
     )
 
     override fun getAppLauncherName() = getString(R.string.app_launcher_name)
+
+    override fun getRepositoryName() = "Phone"
 }

app/src/main/res/layout/activity_settings.xml

@@ -80,13 +80,13 @@
 
             <RelativeLayout
                 android:id="@+id/settings_use_english_holder"
-                style="@style/SettingsHolderCheckboxStyle"
+                style="@style/SettingsHolderSwitchStyle"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content">
 
-                <org.fossify.commons.views.MyAppCompatCheckbox
+                <org.fossify.commons.views.MyMaterialSwitch
                     android:id="@+id/settings_use_english"
-                    style="@style/SettingsCheckboxStyle"
+                    style="@style/SettingsSwitchStyle"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
                     android:text="@string/use_english_language" />
@@ -169,15 +169,30 @@
 
             </RelativeLayout>
 
+            <RelativeLayout
+                android:id="@+id/settings_start_name_with_surname_holder"
+                style="@style/SettingsHolderSwitchStyle"
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content">
+
+                <org.fossify.commons.views.MyMaterialSwitch
+                    android:id="@+id/settings_start_name_with_surname"
+                    style="@style/SettingsSwitchStyle"
+                    android:layout_width="match_parent"
+                    android:layout_height="wrap_content"
+                    android:text="@string/start_name_with_surname" />
+
+            </RelativeLayout>
+
             <RelativeLayout
                 android:id="@+id/settings_format_phone_numbers_holder"
-                style="@style/SettingsHolderCheckboxStyle"
+                style="@style/SettingsHolderSwitchStyle"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content">
 
-                <org.fossify.commons.views.MyAppCompatCheckbox
+                <org.fossify.commons.views.MyMaterialSwitch
                     android:id="@+id/settings_format_phone_numbers"
-                    style="@style/SettingsCheckboxStyle"
+                    style="@style/SettingsSwitchStyle"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
                     android:text="@string/format_phone_numbers" />
@@ -235,13 +250,13 @@
 
             <RelativeLayout
                 android:id="@+id/settings_open_dialpad_at_launch_holder"
-                style="@style/SettingsHolderCheckboxStyle"
+                style="@style/SettingsHolderSwitchStyle"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content">
 
-                <org.fossify.commons.views.MyAppCompatCheckbox
+                <org.fossify.commons.views.MyMaterialSwitch
                     android:id="@+id/settings_open_dialpad_at_launch"
-                    style="@style/SettingsCheckboxStyle"
+                    style="@style/SettingsSwitchStyle"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
                     android:text="@string/open_dialpad_by_default" />
@@ -291,13 +306,13 @@
 
             <RelativeLayout
                 android:id="@+id/settings_group_subsequent_calls_holder"
-                style="@style/SettingsHolderCheckboxStyle"
+                style="@style/SettingsHolderSwitchStyle"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content">
 
-                <org.fossify.commons.views.MyAppCompatCheckbox
+                <org.fossify.commons.views.MyMaterialSwitch
                     android:id="@+id/settings_group_subsequent_calls"
-                    style="@style/SettingsCheckboxStyle"
+                    style="@style/SettingsSwitchStyle"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
                     android:text="@string/group_subsequent_calls" />
@@ -317,13 +332,13 @@
 
             <RelativeLayout
                 android:id="@+id/settings_show_call_confirmation_holder"
-                style="@style/SettingsHolderCheckboxStyle"
+                style="@style/SettingsHolderSwitchStyle"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content">
 
-                <org.fossify.commons.views.MyAppCompatCheckbox
+                <org.fossify.commons.views.MyMaterialSwitch
                     android:id="@+id/settings_show_call_confirmation"
-                    style="@style/SettingsCheckboxStyle"
+                    style="@style/SettingsSwitchStyle"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
                     android:text="@string/show_call_confirmation_dialog" />
@@ -332,13 +347,13 @@
 
             <RelativeLayout
                 android:id="@+id/settings_disable_proximity_sensor_holder"
-                style="@style/SettingsHolderCheckboxStyle"
+                style="@style/SettingsHolderSwitchStyle"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content">
 
-                <org.fossify.commons.views.MyAppCompatCheckbox
+                <org.fossify.commons.views.MyMaterialSwitch
                     android:id="@+id/settings_disable_proximity_sensor"
-                    style="@style/SettingsCheckboxStyle"
+                    style="@style/SettingsSwitchStyle"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
                     android:text="@string/disable_proximity_sensor" />
@@ -347,13 +362,13 @@
 
             <RelativeLayout
                 android:id="@+id/settings_disable_swipe_to_answer_holder"
-                style="@style/SettingsHolderCheckboxStyle"
+                style="@style/SettingsHolderSwitchStyle"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content">
 
-                <org.fossify.commons.views.MyAppCompatCheckbox
+                <org.fossify.commons.views.MyMaterialSwitch
                     android:id="@+id/settings_disable_swipe_to_answer"
-                    style="@style/SettingsCheckboxStyle"
+                    style="@style/SettingsSwitchStyle"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
                     android:text="@string/disable_swipe_to_answer" />
@@ -362,13 +377,13 @@
 
             <RelativeLayout
                 android:id="@+id/settings_always_show_fullscreen_holder"
-                style="@style/SettingsHolderCheckboxStyle"
+                style="@style/SettingsHolderSwitchStyle"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content">
 
-                <org.fossify.commons.views.MyAppCompatCheckbox
+                <org.fossify.commons.views.MyMaterialSwitch
                     android:id="@+id/settings_always_show_fullscreen"
-                    style="@style/SettingsCheckboxStyle"
+                    style="@style/SettingsSwitchStyle"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
                     android:text="@string/show_incoming_calls_full_screen" />
@@ -403,13 +418,13 @@
 
             <RelativeLayout
                 android:id="@+id/settings_hide_dialpad_numbers_holder"
-                style="@style/SettingsHolderCheckboxStyle"
+                style="@style/SettingsHolderSwitchStyle"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content">
 
-                <org.fossify.commons.views.MyAppCompatCheckbox
+                <org.fossify.commons.views.MyMaterialSwitch
                     android:id="@+id/settings_hide_dialpad_numbers"
-                    style="@style/SettingsCheckboxStyle"
+                    style="@style/SettingsSwitchStyle"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
                     android:text="@string/hide_dialpad_numbers" />
@@ -418,13 +433,13 @@
 
             <RelativeLayout
                 android:id="@+id/settings_dialpad_vibration_holder"
-                style="@style/SettingsHolderCheckboxStyle"
+                style="@style/SettingsHolderSwitchStyle"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content">
 
-                <org.fossify.commons.views.MyAppCompatCheckbox
+                <org.fossify.commons.views.MyMaterialSwitch
                     android:id="@+id/settings_dialpad_vibration"
-                    style="@style/SettingsCheckboxStyle"
+                    style="@style/SettingsSwitchStyle"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
                     android:text="@string/dialpad_vibrations" />
@@ -433,13 +448,13 @@
 
             <RelativeLayout
                 android:id="@+id/settings_dialpad_beeps_holder"
-                style="@style/SettingsHolderCheckboxStyle"
+                style="@style/SettingsHolderSwitchStyle"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content">
 
-                <org.fossify.commons.views.MyAppCompatCheckbox
+                <org.fossify.commons.views.MyMaterialSwitch
                     android:id="@+id/settings_dialpad_beeps"
-                    style="@style/SettingsCheckboxStyle"
+                    style="@style/SettingsSwitchStyle"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
                     android:text="@string/dialpad_beeps" />