Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment package to nuget issue #93

Merged

Conversation

Dwicahya94
Copy link
Contributor

@Dwicahya94 Dwicahya94 commented Oct 22, 2024

References

Summary

  • Fix publishing nuget package issue due to known bug after migrating to NET 8. true value from --no-symbols true or -n true need to be removed from script. Or, removed the option entirely.

image

Before and After removing true value from -n / --no-symbols. Same result as if those options were removed from the script

Screenshot 2024-10-23 062813

Code Checklist

  • Branch name using correct convention
  • Coding standards adhered to
  • PR is as small as it can be (no bundled changes)
  • Tests added

JIRA Checklist

  • Technical notes / screenshots
  • Deployment plan
  • Performance results (if applicable)

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.57%. Comparing base (79417a5) to head (484e566).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #93   +/-   ##
=======================================
  Coverage   88.57%   88.57%           
=======================================
  Files          17       17           
  Lines         394      394           
  Branches       22       22           
=======================================
  Hits          349      349           
  Misses         38       38           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dwicahya94 Dwicahya94 marked this pull request as ready for review October 22, 2024 23:40
@RPM1984 RPM1984 merged commit 5b46718 into Homely:master Oct 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants