Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Homely.AspNetCore.Mvc.Helpers to show local datetime instead of UTC #92

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

Dwicahya94
Copy link
Contributor

@Dwicahya94 Dwicahya94 commented Oct 22, 2024

References

Summary

The API home endpoint is currently showing the build date and applications started with UTC format. It needs to be changed into local date time format

  • Migrate projects to NET 8
  • Bump nuget packages versions
  • Bump GitHub actions versions
  • Fix existing UTs

Code Checklist

  • Branch name using correct convention
  • Coding standards adhered to
  • PR is as small as it can be (no bundled changes)
  • Tests added

JIRA Checklist

  • Technical notes / screenshots
  • Deployment plan
  • Performance results (if applicable)

Dwi Cahya Pramanda added 2 commits October 22, 2024 14:39
Migrate to NET 8
Bump NET Packages
Fix existing UT errors
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.57%. Comparing base (8cb9862) to head (c65b67c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
- Coverage   90.35%   88.57%   -1.78%     
==========================================
  Files          17       17              
  Lines         394      394              
  Branches        0       22      +22     
==========================================
- Hits          356      349       -7     
  Misses         38       38              
- Partials        0        7       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RPM1984 RPM1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nice cleanup here too 👏

@RPM1984 RPM1984 merged commit 79417a5 into Homely:master Oct 22, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants