Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typedb 2.29.1 #194822

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

typedb 2.29.1 #194822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions Formula/t/typedb.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
class Typedb < Formula
desc "Strongly-typed database with a rich and logical type system"
homepage "https://vaticle.com/"
url "https://github.com/vaticle/typedb/releases/download/2.23.0/typedb-all-mac-2.23.0.zip"
sha256 "93a5540c02e3e4f4b7783a2d14a8907dcfde3c2b051984ca6b2df79abc3830ce"
license "AGPL-3.0-or-later"
license "MPL-2.0"

bottle do
rebuild 1
Expand All @@ -12,6 +10,27 @@ class Typedb < Formula

depends_on "openjdk"

on_arm do
on_macos do
url "https://github.com/typedb/typedb/releases/download/2.29.1/typedb-all-mac-arm64-2.29.1.zip"
sha256 "1270565acd7d5c61475831dac408f2069533ecf4ffee416ae474962ce1a71603"
end
on_linux do
url "https://github.com/typedb/typedb/releases/download/2.29.1/typedb-all-linux-arm64-2.29.1.tar.gz"
sha256 "4846e0496c9d90542fe677bd44ec78fe31a056a07770b5b53703ea0c781e99d6"
end
end
on_intel do
on_macos do
url "https://github.com/typedb/typedb/releases/download/2.29.1/typedb-all-mac-x86_64-2.29.1.zip"
sha256 "82ad962d3248d0a883d129a01b7593960031758283270128601a948be637854a"
end
on_linux do
url "https://github.com/typedb/typedb/releases/download/2.29.1/typedb-all-linux-x86_64-2.29.1.tar.gz"
sha256 "4b358ee8beb76f856ca21c61979828f9e082f00591942bf770a1cb2aa53fe4bf"
end
end
Comment on lines +13 to +32
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks suspicious TBH. Doesn't seem compatible with https://docs.brew.sh/Acceptable-Formulae#we-dont-like-binary-formulae

Copy link
Member Author

@samford samford Oct 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diffing the extracted files and running pkgdiff on the differing jar files, there are currently two that contain OS/arch-specific dynamic libraries:

  • console/lib/com-vaticle-typedb-typedb-driver-jni-(linux|macosx)-(arm64|x86_64)-2.29.0.jar
  • server/lib/com-google-ortools-ortools-(darwin|linux)-(aarch64|x86-64)-9-6-2534.jar

The 2.23.0 release provides both the ARM and x86 ortools files and it doesn't contain the aforementioned driver-jni file.

There are other jar files in server/lib (e.g., com-vaticle-typedb-typedb-core-common-2.29.1.jar) that differ only in META-INF/MANIFEST.MF (e.g., Target-Label: //common:common-mac-arm64 vs. Target-Label: //common:common-linux-x86_64). The 2.23.0 release omits the arch from the Target-Label (e.g., common-mac, common-linux).


def install
libexec.install Dir["*"]
mkdir_p var/"typedb/data"
Expand All @@ -23,6 +42,6 @@ def install
end

test do
assert_match "A STRONGLY-TYPED DATABASE", shell_output("#{bin}/typedb server --help")
assert_match "THE POLYMORPHIC DATABASE", shell_output("#{bin}/typedb server --help")
end
end
Loading