Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go 1.21.7 #161976

Merged
merged 4 commits into from
Feb 8, 2024
Merged

go 1.21.7 #161976

merged 4 commits into from
Feb 8, 2024

Conversation

stefanb
Copy link
Member

@stefanb stefanb commented Feb 6, 2024 •
edited
Loading

Announcement: https://groups.google.com/g/golang-announce/c/Qdkw_yX60TE/m/no34wVjNBwAJ

Release notes: https://go.dev/doc/devel/release#go1.21.7

go1.21.7 (released 2024-02-06) includes fixes to the compiler, the go command, the runtime, and the crypto/x509 package. See the Go 1.21.7 milestone on our issue tracker for details.

Created with brew bump-formula-pr.

  • resource blocks have been checked for updates.

@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. labels Feb 6, 2024
@stefanb
Copy link
Member Author

stefanb commented Feb 6, 2024

It probably needs tags CI-no-fail-fast, long build and CI-long-timeout, similar to:

@stefanb stefanb mentioned this pull request Feb 7, 2024
Merged
@alebcay alebcay added long build Set a long timeout for formula testing CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Feb 7, 2024
stefanb added a commit to stefanb/homebrew-core that referenced this pull request Feb 7, 2024
@stefanb
cog: update checksum
9b8f8cb 
It seems v0.9.4 it was re-tagged again, similar to
* Homebrew#158001

This affects
* Homebrew#161976
* Homebrew#157782
@stefanb stefanb mentioned this pull request Feb 7, 2024
Merged
6 tasks
@stefanb
Copy link
Member Author

stefanb commented Feb 7, 2024 •
edited
Loading

Cog is failing, handled in a separate PR:

to not block this one.

@stefanb stefanb mentioned this pull request Feb 7, 2024
Closed
@stefanb
Copy link
Member Author

stefanb commented Feb 7, 2024 •
edited
Loading

emp is failing due to webrick being unavailable for testing:

  An exception occurred within a child process:
    LoadError: cannot load such file -- webrick

Likely not related to Go upgrade, but a homebrew issue. Not sure what can be done about that.

@Porkepix
Copy link
Contributor

Porkepix commented Feb 7, 2024

Cog is failing, handled in a separate PR:

* [cog: update checksum #162013](https://github.com/Homebrew/homebrew-core/pull/162013) 👀

to not block this one.

Maybe better doing it/rebasing it after merge then, so have it compiled using latest compiler release? (Or even the 1.22, but might take some time I guess)

@SMillerDev
Copy link
Member

Could you make a pr where you revision bump emp? So we can figure that out later?

@stefanb stefanb mentioned this pull request Feb 7, 2024
Merged
6 tasks
@stefanb
Copy link
Member Author

stefanb commented Feb 7, 2024 •
edited
Loading

Could you make a pr where you revision bump emp? So we can figure that out later?

Created:

and it reproduces the problem, unrelated to any Go changes.

@stefanb
Copy link
Member Author

stefanb commented Feb 7, 2024 •
edited
Loading

Problematic formulae from https://github.com/Homebrew/homebrew-core/actions/runs/7806004183/job/21303080975?pr=161976:

  • cog: cog: update checksum #162013
  • emp: webrick problem - emp: use TCPServer instead of WEBrick for test #162041
  • gollum: github.com/CrowdStrike/go-metrics-prometheus seems gone trivago/gollum#265
  • ibazel
  • kapacitor Please upgrade flux to 0.191.0 influxdata/kapacitor#2769
  • lux: lux: fix test #162073
  • Resource: oggfile ==> Downloading https://upload.wikimedia.org/wikipedia/commons/c/c8/Example.ogg Downloaded to: /Users/brew/Library/Caches/Homebrew/downloads/e163886f3d57674f022eb584f07ef6d71dbbf58fb39c481a2c516ce6bfd4af18--Example.ogg SHA256: f57b56d8aae4c847cf01224fb45293610d801cfdac43d932b5eeab1cd318182a Error: Download failed: Homebrew-installedcurl is not installed for: https://downloads.xiph.org/releases/vorbis/libvorbis-1.3.7.tar.xz
  • ssllabs-scan: temporary network issue in test: Error: /07 09:29:37 [ERROR] HTTP request failed: Get "https://api.ssllabs.com/api/v3/info": read tcp 192.168.64.10:64542->64.41.200.100:443: read: connection reset by peer (ref#2)
  • tkey-ssh-agent: hash mismatch
  • toxiproxy: webrick problem in test
  • trezor-bridge: Release a version built with supported Go version  trezor/trezord-go#301
  • trojan-go: webrick problem in test
  • Resource: oggfile ==> Downloading https://upload.wikimedia.org/wikipedia/commons/c/c8/Example.ogg Downloaded to: /Users/brew/Library/Caches/Homebrew/downloads/e163886f3d57674f022eb584f07ef6d71dbbf58fb39c481a2c516ce6bfd4af18--Example.ogg SHA256: f57b56d8aae4c847cf01224fb45293610d801cfdac43d932b5eeab1cd318182a Error: Download failed: Homebrew-installed curl is not installed for: https://downloads.xiph.org/releases/vorbis/libvorbis-1.3.7.tar.xz
  • wtfutil
  • zrok: hash mismatch - ==> Downloading https://github.com/openziti/zrok/archive/refs/tags/v0.4.23.tar.gz ==> Downloading from https://codeload.github.com/openziti/zrok/tar.gz/refs/tags/v0.4.23 Downloaded to: /Users/brew/Library/Caches/Homebrew/downloads/1d5a0aa58eb7f9a54fad745f57d0f557d70cdc1004c6e6c67b0ee3e1c987cb15--zrok-0.4.23.tar.gz SHA256: 4ca9c52b8ad56498fe3cc73a65e0f6381f1d1afa2f9be2c569dc6f2e3fb810f9 Warning: Formula reports different sha256: 020a1875fa7a62bccbeff6c21fc9292a02c97283796dfe7b4820be0b6c6c7946

This was referenced Feb 7, 2024
Open
Merged
@stefanb
Copy link
Member Author

stefanb commented Feb 8, 2024 •
edited
Loading

Judging from the errors so far it seems that the Go 1.21.7 is ok to merge and all of the problems are with individual projects / formulae.

@chenrui333
Copy link
Member

considering this is just a patch version update, we can also probably skip building the dependants from source

@Porkepix
Copy link
Contributor

Porkepix commented Feb 8, 2024

It's building every dependents from source again @chenrui333

@chenrui333 chenrui333 removed the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Feb 8, 2024
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Feb 8, 2024
@chenrui333 chenrui333 added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Feb 8, 2024
@Porkepix
Copy link
Contributor

Porkepix commented Feb 8, 2024

When not rebuilding every dependent, I guess the long build isn't needed anymore?

@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Feb 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Feb 8, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 8, 2024
Merged via the queue into Homebrew:master with commit 96a491a Feb 8, 2024
12 checks passed
@stefanb stefanb deleted the bump-go-1.21.7 branch February 8, 2024 12:58
@chenrui333 chenrui333 removed the long build Set a long timeout for formula testing label Feb 8, 2024
alebcay added a commit to stefanb/homebrew-core that referenced this pull request Feb 10, 2024
@alebcay
emp: use TCPServer instead of WEBrick for test
9bf26f8 
Related:
* Homebrew#161976
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@iMichka iMichka iMichka approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@stefanb @Porkepix @SMillerDev @chenrui333 @iMichka @BrewTestBot @alebcay