Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew-gem 0.7.0 #1233

Merged
merged 1 commit into from
May 17, 2016
Merged

brew-gem 0.7.0 #1233

merged 1 commit into from
May 17, 2016

Conversation

nicksieger
Copy link
Contributor

@nicksieger nicksieger commented May 17, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --strict --online <formula> (after doing brew install <formula>)?

The only issue with brew audit --strict --online is that sportngin/brew-gem is a forked repository, but it has been that way since before this new release.


bottle :unneeded

def install
lib.install Dir["lib/*"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this neeed by brew-gem or is it useful standalone?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of the internals were moved there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See sportngin/brew-gem#23 for more information on that

@ilovezfs
Copy link
Contributor

@nicksieger

>> `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
=> [".gitignore", ".octopolo.yml", ".rspec", ".ruby-version", ".travis.yml", "Gemfile", "LICENSE", "README.md", "Rakefile", "bin/brew-gem", "brew-gem.gemspec", "lib/brew/gem.rb", "lib/brew/gem/cli.rb", "lib/brew/gem/formula.rb.erb", "lib/brew/gem/version.rb"]

Do you not also want to install your LICENSE and README.md files?

@DomT4
Copy link
Member

DomT4 commented May 17, 2016

Do you not also want to install your LICENSE and README.md files?

This happens automagically in a lot of cases FWIW, including here:

ls -1 $(brew --prefix brew-gem)
INSTALL_RECEIPT.json
LICENSE
README.md
bin

@ilovezfs
Copy link
Contributor

interesting... where's that voodoo magic?

@DomT4
Copy link
Member

DomT4 commented May 17, 2016

The magic is metafiles and invoked by build here.

@nicksieger
Copy link
Contributor Author

Ok, I'm new to formula dev and not clear on the difference between /usr/local/opt (prefix) and /usr/local/Cellar/<formula>/<version>. I can certainly update the formula to install the license and readme to the cellar, if that's the convention.

@DomT4
Copy link
Member

DomT4 commented May 17, 2016

Ok, I'm new to formula dev and not clear on the difference between /usr/local/opt (prefix) and /usr/local/Cellar//.

The former is just an unversioned symlink to the latter, essentially.

I can certainly update the formula to install the license and readme to the cellar, if that's the convention.

Doesn't seem necessary here. It's happening automatically.

@nicksieger
Copy link
Contributor Author

Aha, sure enough. Thanks. Let me know if anyone sees any other issues that need resolution.

@MikeMcQuaid MikeMcQuaid merged commit 3c60fb0 into Homebrew:master May 17, 2016
@MikeMcQuaid
Copy link
Member

Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

@nicksieger nicksieger deleted the brew-gem-0.7.0 branch May 17, 2016 19:05
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants