-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
brew-gem 0.7.0 #1233
brew-gem 0.7.0 #1233
Conversation
|
||
bottle :unneeded | ||
|
||
def install | ||
lib.install Dir["lib/*"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this neeed by brew-gem
or is it useful standalone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most of the internals were moved there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See sportngin/brew-gem#23 for more information on that
Do you not also want to install your LICENSE and README.md files? |
This happens automagically in a lot of cases FWIW, including here:
|
interesting... where's that voodoo magic? |
Ok, I'm new to formula dev and not clear on the difference between |
The former is just an unversioned symlink to the latter, essentially.
Doesn't seem necessary here. It's happening automatically. |
Aha, sure enough. Thanks. Let me know if anyone sees any other issues that need resolution. |
Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock! |
brew install <formula>
(where<formula>
is the name of the formula you're submitting)?brew audit --strict --online <formula>
(after doingbrew install <formula>
)?The only issue with
brew audit --strict --online
is that sportngin/brew-gem is a forked repository, but it has been that way since before this new release.