-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Update alacritty from 0.4.0 to 0.4.1 (#75324)" #76879
Conversation
This reverts commit 3e733d8. alacritty/alacritty#3188 is a fairly significant bug.
if the bug is so significant, then upstream should pull the release. if they do, we can follow. |
Hm, what does "pulling a release" mean for a generic project? The release was done, it's out. There's not much benefit in deleting the artifacts, they're moving forward, and will put out a new release when their (transitive) dep is fixed. Up to you guys though. |
It means taking back the release, which is standard procedure in these cases. If a severe bug happens, saying “oh well, we’ve released it now so let’s leave it out for new people to be affected” isn’t good practice.
There is a ton of benefit. Most people don’t follow bug trackers, they download the software and get on with their lives. The longer this stays out, the more people will get the buggy release and the worse it will be for the reputation of their software. That version has been out in cask form for a month and is highly popular:
Maybe this is affecting a minority of people, or maybe upstream is choosing to keep that version up for other reasons. Either way, I agree we should follow their lead on this one, they’re the experts on their software. If they do an official recommendation that people should stay on Thank you anyway for the PR and letting us know. |
I won't belabor the point, since I don't really want to argue here, it's your repo, I've already fixed this for myself (so presumably others who want this will chime in if they do, otherwise hopefully they just put a release out), but alacritty is cross-platform software. The recommendation they have is to go back to 0.4.0, as linked in that issue, they're not going to delete the release for a subset of their users (which I agree with, deleting stuff that's out is not great practice, but it sounds like you disagree). If you already saw that (that their recommendation is to go back to 0.4.0) and still want to close fair enough, but just making sure to point that out. |
they recommend to go back to 0.4.0 if (and only if) you are affected. if they thought /everyone/ should go back to 0.4.0, the 0.4.1 version wouldn't be available for download anymore. with any complex project, there are always be people that think the latest release is unusable because of a showstopper bug. the only sane thing for us to do here is to follow upstream - if they pull a release, we should follow. i don't see any other procedure as working. who should we trust about what bugs are critical and what are not? if you think it though we can only trust the upstream vendor and they have decided to keep the release. |
Agreed, neither do I. Whichever way it goes, we’re still grateful for your submission.
I haven’t read it all, but I’ve only found a regular user (not repo member) making that suggestion and a contributor (also not member) recommending building from source. Are you able to point me to the specific recommendation made by a maintainer?
They wouldn’t need to delete whole release, simply remove the downloads for the affected OS. That’s not uncommon; often multi-platform software has releases for a subset of supported OSs.
That is appreciated. If you can point to a recommendation made by a project maintainer, I’ll gladly take another look. |
Thanks, and same, I'm sure telling fly-by-contributors the same thing over and over again isn't fun.
No sorry, it's what you saw from kchibisov (who I just saw had significant numbers of contributions, they were like #3 or something in the list). Anyways, fair enough on just leaving it until they clarify what they recommend or hopefully just push out a fix. Maybe I'll leave a comment on the ticket and see what they say. |
This doesn't affect all Alacritty users though, but it is a very significant issue for the macOS portion. Since 100% of homebrew-cask downloading Alacritty users are on macOS, it makes (even) more sense for the homebrew-cask version to revert than it does for Alacritty as a whole. |
This reverts commit 3e733d8.
alacritty/alacritty#3188 is a fairly significant bug.
After making all changes to the cask:
brew cask audit --download {{cask_file}}
is error-free.brew cask style --fix {{cask_file}}
reports no offenses.