Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

laverna: deprecate #163592

Merged
merged 2 commits into from
Jan 2, 2024
Merged

laverna: deprecate #163592

merged 2 commits into from
Jan 2, 2024

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Jan 1, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

depends on #163591

@BrewTestBot BrewTestBot added missing description Cask is missing a description, please add one. missing zap Cask is missing a zap stanza, please add one. labels Jan 1, 2024
Casks/l/laverna.rb Outdated Show resolved Hide resolved
@chenrui333 chenrui333 marked this pull request as ready for review January 1, 2024 22:41
@chenrui333 chenrui333 requested a review from SMillerDev January 1, 2024 22:41
@chenrui333 chenrui333 added the ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. label Jan 1, 2024
@BrewTestBot BrewTestBot removed the missing description Cask is missing a description, please add one. label Jan 1, 2024
Casks/l/laverna.rb Outdated Show resolved Hide resolved
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 requested a review from bevanjkay January 2, 2024 00:30
@chenrui333 chenrui333 added the cask deprecated Cask deprecated label Jan 2, 2024
@bevanjkay bevanjkay enabled auto-merge January 2, 2024 00:40
@bevanjkay bevanjkay merged commit 2d6e69b into Homebrew:master Jan 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cask deprecated Cask deprecated ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. missing zap Cask is missing a zap stanza, please add one.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants