Remove MathNet.Numerics, embed the one class we actually used from it #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JFriel
reviewed
Aug 9, 2024
…d comment origins
Actually remove Mathnet.Numerics now we aren't using it
Newer Ubuntu, and use the 8.x SDK not 6.x
JFriel
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only used part of a single weighted RNG class from MathNet.Numerics, so no need to import the whole library for a single function!
Embed directly, update PACKAGES.md accordingly.
Note: this resolves the issue HicServices/RDMP#1858 downstream in RDMP.