Merge pull request #85 from HicServices/feature/nequ

Equ not needed, only handled comparing two strings anyway....

Packages.md

@@ -12,4 +12,3 @@
 | RestSharp                         | [GitHub](https://github.com/restsharp/RestSharp)        | [Apache 2.0](https://github.com/restsharp/RestSharp/blob/dev/LICENSE.txt) | REST API wrapper                              |                            |
 | System.ServiceModel.Http          | [GitHub](https://github.com/dotnet/corefx)              | [MIT](https://opensource.org/licenses/MIT)                                | Enables interaction with Web APIs (SciStore)  |                            |
 | Microsoft.XmlSerializer.Generator | [Microsoft](https://learn.microsoft.com/en-us/dotnet/core/additional-tools/xml-serializer-generator) | [MIT](https://opensource.org/licenses/MIT) | XML handling improvements |
-| Equ | [GitHub](https://github.com/thedmi/Equ) | [MIT](https://opensource.org/licenses/MIT) | Fast, convention-based, zero-code equality functions for .NET |

SCIStorePlugin/SCIStorePlugin.csproj

@@ -126,7 +126,6 @@
 		<Compile Include="..\SharedAssemblyInfo.cs" Link="SharedAssemblyInfo.cs" />
 	</ItemGroup>
 	<ItemGroup>
-		<PackageReference Include="Equ" Version="2.3.0" />
 		<PackageReference Include="Microsoft.XmlSerializer.Generator" Version="8.0.0" />
 		<PackageReference Include="System.ServiceModel.Http" Version="6.2.0" />
 	</ItemGroup>

SCIStorePlugin/SciStoreRecord.cs

@@ -1,11 +1,10 @@
 using System;
 using Rdmp.Core.ReusableLibraryCode;
-using Equ;
 using Rdmp.Core.ReusableLibraryCode.Annotations;
 
 namespace SCIStorePlugin;
 
-public sealed class SciStoreRecord : PropertywiseEquatable<SciStoreRecord>, IEquatable<SciStoreRecord>
+public sealed class SciStoreRecord : IEquatable<SciStoreRecord>
 {
     public string CHI;
 
@@ -28,7 +27,6 @@ public string TestReportID
     private string _labNumber;
     private string _testReportId;
 
-    [MemberwiseEqualityIgnore]
     public string Dept { get; set; }
 
     public static bool operator ==([CanBeNull] SciStoreRecord left, [CanBeNull] SciStoreRecord right)
@@ -43,11 +41,18 @@ public string TestReportID
 
     public override bool Equals(object obj)
     {
-        return obj is SciStoreRecord r && Equals(r);
+        return ReferenceEquals(this, obj) || obj is SciStoreRecord other && Equals(other);
     }
 
     public override int GetHashCode()
     {
-        return HashCode.Combine(LabNumber, TestReportID);
+        return HashCode.Combine(_labNumber, _testReportId);
+    }
+
+    public bool Equals(SciStoreRecord other)
+    {
+        if (other is null) return false;
+        if (ReferenceEquals(this, other)) return true;
+        return _labNumber == other._labNumber && _testReportId == other._testReportId;
     }
 }