throw for bad chi

HicServices · Jul 17, 2024 · 0539bae · 0539bae
1 parent ed0da23
commit 0539bae
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 17 deletions.
diff --git a/SCIStorePlugin/Attachers/SciStoreAttacher.cs b/SCIStorePlugin/Attachers/SciStoreAttacher.cs
@@ -146,22 +146,22 @@ private void BulkInsertDataTable(DataTable dataTable, IDataLoadJob job)
 
         var tbl = _dbInfo.ExpectTable(dataTable.TableName);
         using var blk = tbl.BeginBulkInsert();
-        DataTable ndt = dataTable.Clone();
-        foreach (var row in dataTable.Rows)
-        {
-            try
-            {
-                ndt = dataTable.Clone();
-                ndt.Rows.Add(row);
-                blk.Upload(ndt);
-            }
-            catch (Exception e)
-            {
-                job.OnNotify(this, new NotifyEventArgs(ProgressEventType.Warning,
-               $"Skipped a row due to error: {e.Message}.", e));
-            }
-        }
-        //blk.Upload(dataTable);
+        //DataTable ndt = dataTable.Clone();
+        //foreach (var row in dataTable.Rows)
+        //{
+        //    try
+        //    {
+        //        ndt = dataTable.Clone();
+        //        ndt.Rows.Add(row);
+        //        blk.Upload(ndt);
+        //    }
+        //    catch (Exception e)
+        //    {
+        //        job.OnNotify(this, new NotifyEventArgs(ProgressEventType.Warning,
+        //       $"Skipped a row due to error: {e.Message}.", e));
+        //    }
+        //}
+        blk.Upload(dataTable);
     }
 
     public bool SilentRunning { get; set; }

diff --git a/SCIStorePlugin/Data/SciStoreHeader.cs b/SCIStorePlugin/Data/SciStoreHeader.cs
@@ -109,7 +109,8 @@ private static string CleanCHI(string chi)
         // encountered in Fife Haematology load
         if (!string.IsNullOrWhiteSpace(chi) && chi.Equals("Temp Residen"))
             return chi[..10];
-
+        if (chi.Length > 10)
+            throw new Exception($"CHI '{chi}' was too long");
         return chi;
     }