Postgres:ListDatabases - add default database to connection #287
Conversation
|
Is reverting to the #273 behaviour the best route here, or just using whatever database is in the connection string? We can't assume postgres exists either, but if we use the one the user specified that's defensible. |
In the case of RDMP checking if the database exists before creating it, I suppose we could just catch the .Exists() call and if the error is the db does not exists error then assume it does not exist and we should create it |
| @@ -66,7 +66,7 @@ public override IEnumerable<string> ListDatabases(DbConnectionStringBuilder buil | |||
| //create a copy so as not to corrupt the original | |||
| var b = new NpgsqlConnectionStringBuilder(builder.ConnectionString) | |||
| { | |||
| Database = null, | |||
| Database = "postgres", //Use the default database, otherwise Npgsql will try to connect to a database with the same name as the user | |||
There was a problem hiding this comment.
We're actually best deleting this line, rather than assigning any value to it.
There was a problem hiding this comment.
If we delete this line it will try to connect to a db with the same name as the user connecting. Is that the behaviour we want?
There was a problem hiding this comment.
No, it will connect to whatever db the user specified in the connection string, which is the only one we can reasonably rely on existing. We can't create databases at all on Oracle (it has a very "Oracle" approach to that!) and won't normally have the right permissions to do that on HIC or EPCC systems either, what matters is being able to connect reliably with the connection string provided. If this code fails with line 69 deleted, it means the user gave us an invalid connection string and it's obvious how to fix it.
There was a problem hiding this comment.
That makes sense, suppose the real issue is finding a clean way of dealing with the associated RDMP issue...
Issue raised in RDMP - HicServices/RDMP#1873
The issue appears as though when connection to a Postgres server, if no database is specified, it will Ngpsql will attempt to connect to a database with the same name as the user.
This fix uses the default postgres database to connect to in order to enumerate the databases on the server