Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/lingua nostra - default_tz #6

Merged
merged 3 commits into from
Mar 29, 2021
Merged

Feat/lingua nostra - default_tz #6

merged 3 commits into from
Mar 29, 2021

Conversation

JarbasAl
Copy link

@JarbasAl JarbasAl commented Mar 29, 2021 •
edited
Loading

migrates from lingua_franca to https://github.com/HelloChatterbox/lingua-nostra

ensures proper timezone support, relates to #2 and MycroftAI/lingua-franca#180

this does not get us out of sync with mycroft unless MycroftAI/lingua-franca#180 is rejected

some skills might break if they can't handle timezone aware datetimes, but we should not include bugs in mycroft-lib because of bugs in skills

@JarbasAl JarbasAl added bug Something isn't working patch not present in upstream labels Mar 29, 2021
@JarbasAl JarbasAl merged commit 5b2a268 into dev Mar 29, 2021
@JarbasAl JarbasAl mentioned this pull request Mar 31, 2021
Merged
JarbasAl added a commit that referenced this pull request Apr 2, 2021
@JarbasAl
Feat/lingua nostra (#6)
e20701b 
* feat/lingua_nostra

Co-authored-by: jarbasal <[email protected]>
@JarbasAl JarbasAl added the packaging refactored for packaging reasons label Apr 3, 2021
@JarbasAl JarbasAl changed the title Feat/lingua nostra Feat/lingua nostra - default_tz Apr 12, 2021
@JarbasAl JarbasAl removed the bug Something isn't working label Apr 12, 2021
JarbasAl added a commit that referenced this pull request Apr 12, 2021
@JarbasAl
Feat/lingua nostra (#6)
f13db73 
* feat/lingua_nostra

Co-authored-by: jarbasal <[email protected]>
JarbasAl added a commit that referenced this pull request Apr 12, 2021
@JarbasAl
Feat/lingua nostra (#6)
256d859 
* feat/lingua_nostra

Co-authored-by: jarbasal <[email protected]>
JarbasAl added a commit that referenced this pull request Apr 12, 2021
@JarbasAl
Feat/lingua nostra (#6)
eb7f6ad 
* feat/lingua_nostra

Co-authored-by: jarbasal <[email protected]>
JarbasAl added a commit that referenced this pull request Apr 12, 2021
@JarbasAl
Feat/lingua nostra (#6)(#7)
ca9b85c 
Co-authored-by: jarbasal <[email protected]>
JarbasAl added a commit that referenced this pull request Apr 12, 2021
@JarbasAl
Feat/lingua nostra (#6)(#7)
4b7e1f1 
Co-authored-by: jarbasal <[email protected]>
JarbasAl added a commit that referenced this pull request Apr 12, 2021
@JarbasAl
Feat/lingua nostra (#6)(#7)
ca8c0e9 
Co-authored-by: jarbasal <[email protected]>
JarbasAl added a commit that referenced this pull request Apr 12, 2021
@JarbasAl
Feat/lingua nostra (#6)(#7)
2e776e7 
Co-authored-by: jarbasal <[email protected]>
JarbasAl added a commit that referenced this pull request Apr 12, 2021
@JarbasAl
Feat/lingua nostra (#6)(#7)
2617698 
Co-authored-by: jarbasal <[email protected]>
JarbasAl added a commit that referenced this pull request Apr 12, 2021
@JarbasAl
Feat/lingua nostra (#6)(#7)
43c66f5 
Co-authored-by: jarbasal <[email protected]>
JarbasAl added a commit that referenced this pull request Apr 12, 2021
@JarbasAl
Feat/lingua nostra (#6)(#7)
7a09f6b 
Co-authored-by: jarbasal <[email protected]>
JarbasAl added a commit that referenced this pull request Apr 12, 2021
@JarbasAl
Feat/lingua nostra (#6)(#7)
f0a2c12 
Co-authored-by: jarbasal <[email protected]>

2021.4.2
JarbasAl added a commit that referenced this pull request May 6, 2021
@JarbasAl
Feat/lingua nostra (#6)(#7)
10b5ed6 
Co-authored-by: jarbasal <[email protected]>

2021.4.2
JarbasAl added a commit that referenced this pull request Jul 1, 2021
@JarbasAl
feat/locale_switching + packaging/LN+LF_support (#6)(#7)(#27)(#62)
fe14f4b 
- integration of timezone support with LN (was a dummy method until now)
- lingua_franca and lingua_nostra need to be able to coexist
	- skills might be importing one of those libs directly
- mycroft-lib will call property setters (lang/timezone) for both libs if possible
- all other wrapped methods (`mycroft.util.parse` + `mycroft.util.format` + `mycroft.util.time`) will give preference to LN if it is available, use LF otherwise
	- this should be irrelevant for end users since LN is a drop in replacement
JarbasAl added a commit that referenced this pull request Jul 1, 2021
@JarbasAl
feat/locale_switching + packaging/LN+LF_support (#6)(#7)(#27)(#62)
7a2dbcb 
- integration of timezone support with LN (was a dummy method until now)
- lingua_franca and lingua_nostra need to be able to coexist
	- skills might be importing one of those libs directly
- mycroft-lib will call property setters (lang/timezone) for both libs if possible
- all other wrapped methods (`mycroft.util.parse` + `mycroft.util.format` + `mycroft.util.time`) will give preference to LN if it is available, use LF otherwise
	- this should be irrelevant for end users since LN is a drop in replacement
JarbasAl added a commit that referenced this pull request Jul 1, 2021
@JarbasAl
feat/locale_switching + packaging/LN+LF_support (#6)(#7)(#27)(#62)
82b0dbb 
- integration of timezone support with LN (was a dummy method until now)
- lingua_franca and lingua_nostra need to be able to coexist
	- skills might be importing one of those libs directly
- mycroft-lib will call property setters (lang/timezone) for both libs if possible
- all other wrapped methods (`mycroft.util.parse` + `mycroft.util.format` + `mycroft.util.time`) will give preference to LN if it is available, use LF otherwise
	- this should be irrelevant for end users since LN is a drop in replacement
JarbasAl added a commit that referenced this pull request Jul 1, 2021
@JarbasAl
patch/locale_switching + packaging/LN+LF_support (#6)(#7)(#27)(#62)
4708464 
- integration of timezone support with LN (was a dummy method until now)
- lingua_franca and lingua_nostra need to be able to coexist
	- skills might be importing one of those libs directly
- mycroft-lib will call property setters (lang/timezone) for both libs if possible
- all other wrapped methods (`mycroft.util.parse` + `mycroft.util.format` + `mycroft.util.time`) will give preference to LN if it is available, use LF otherwise
	- this should be irrelevant for end users since LN is a drop in replacement
JarbasAl added a commit that referenced this pull request Jul 1, 2021
@JarbasAl
patch/locale_switching + packaging/LN+LF_support (#6)(#7)(#27)(#62)
aa9c72b 
- integration of timezone support with LN (was a dummy method until now)
- lingua_franca and lingua_nostra need to be able to coexist
	- skills might be importing one of those libs directly
- mycroft-lib will call property setters (lang/timezone) for both libs if possible
- all other wrapped methods (`mycroft.util.parse` + `mycroft.util.format` + `mycroft.util.time`) will give preference to LN if it is available, use LF otherwise
	- this should be irrelevant for end users since LN is a drop in replacement
JarbasAl added a commit that referenced this pull request Jul 1, 2021
@JarbasAl
patch/locale_switching + packaging/LN+LF_support (#6)(#7)(#27)(#62)
c7874d3 
- integration of timezone support with LN (was a dummy method until now)
- lingua_franca and lingua_nostra need to be able to coexist
	- skills might be importing one of those libs directly
- mycroft-lib will call property setters (lang/timezone) for both libs if possible
- all other wrapped methods (`mycroft.util.parse` + `mycroft.util.format` + `mycroft.util.time`) will give preference to LN if it is available, use LF otherwise
	- this should be irrelevant for end users since LN is a drop in replacement
JarbasAl added a commit that referenced this pull request Jul 1, 2021
@JarbasAl
patch/locale_switching + packaging/LN+LF_support (#6)(#7)(#27)(#62)
bb28a88 
- integration of timezone support with LN (was a dummy method until now)
- lingua_franca and lingua_nostra need to be able to coexist
	- skills might be importing one of those libs directly
- mycroft-lib will call property setters (lang/timezone) for both libs if possible
- all other wrapped methods (`mycroft.util.parse` + `mycroft.util.format` + `mycroft.util.time`) will give preference to LN if it is available, use LF otherwise
	- this should be irrelevant for end users since LN is a drop in replacement
JarbasAl added a commit that referenced this pull request Jul 1, 2021
@JarbasAl
patch/locale_switching + packaging/LN+LF_support (#6)(#7)(#27)(#62)
6e0f00c 
- integration of timezone support with LN (was a dummy method until now)
- lingua_franca and lingua_nostra need to be able to coexist
	- skills might be importing one of those libs directly
- mycroft-lib will call property setters (lang/timezone) for both libs if possible
- all other wrapped methods (`mycroft.util.parse` + `mycroft.util.format` + `mycroft.util.time`) will give preference to LN if it is available, use LF otherwise
	- this should be irrelevant for end users since LN is a drop in replacement
JarbasAl added a commit that referenced this pull request Jul 1, 2021
@JarbasAl
patch/locale_switching + packaging/LN+LF_support (#6)(#7)(#27)(#62)
3bae999 
- integration of timezone support with LN (was a dummy method until now)
- lingua_franca and lingua_nostra need to be able to coexist
	- skills might be importing one of those libs directly
- mycroft-lib will call property setters (lang/timezone) for both libs if possible
- all other wrapped methods (`mycroft.util.parse` + `mycroft.util.format` + `mycroft.util.time`) will give preference to LN if it is available, use LF otherwise
	- this should be irrelevant for end users since LN is a drop in replacement
JarbasAl added a commit that referenced this pull request Jul 1, 2021
@JarbasAl
patch/locale_switching + packaging/LN+LF_support (#6)(#7)(#27)(#62)
90aa834 
- integration of timezone support with LN (was a dummy method until now)
- lingua_franca and lingua_nostra need to be able to coexist
	- skills might be importing one of those libs directly
- mycroft-lib will call property setters (lang/timezone) for both libs if possible
- all other wrapped methods (`mycroft.util.parse` + `mycroft.util.format` + `mycroft.util.time`) will give preference to LN if it is available, use LF otherwise
	- this should be irrelevant for end users since LN is a drop in replacement
JarbasAl added a commit that referenced this pull request Jul 1, 2021
@JarbasAl
patch/locale_switching + packaging/LN+LF_support (#6)(#7)(#27)(#62)
abf4c4c 
- integration of timezone support with LN (was a dummy method until now)
- lingua_franca and lingua_nostra need to be able to coexist
	- skills might be importing one of those libs directly
- mycroft-lib will call property setters (lang/timezone) for both libs if possible
- all other wrapped methods (`mycroft.util.parse` + `mycroft.util.format` + `mycroft.util.time`) will give preference to LN if it is available, use LF otherwise
	- this should be irrelevant for end users since LN is a drop in replacement
JarbasAl added a commit that referenced this pull request Jul 5, 2021
@JarbasAl
patch/locale_switching + packaging/LN+LF_support (#6)(#7)(#27)(#62)
996e59e 
- integration of timezone support with LN (was a dummy method until now)
- lingua_franca and lingua_nostra need to be able to coexist
	- skills might be importing one of those libs directly
- mycroft-lib will call property setters (lang/timezone) for both libs if possible
- all other wrapped methods (`mycroft.util.parse` + `mycroft.util.format` + `mycroft.util.time`) will give preference to LN if it is available, use LF otherwise
	- this should be irrelevant for end users since LN is a drop in replacement
JarbasAl added a commit that referenced this pull request Jul 22, 2021
@JarbasAl
patch/locale_switching + packaging/LN+LF_support (#6)(#7)(#27)(#62)
196fbb6 
- integration of timezone support with LN (was a dummy method until now)
- lingua_franca and lingua_nostra need to be able to coexist
	- skills might be importing one of those libs directly
- mycroft-lib will call property setters (lang/timezone) for both libs if possible
- all other wrapped methods (`mycroft.util.parse` + `mycroft.util.format` + `mycroft.util.time`) will give preference to LN if it is available, use LF otherwise
	- this should be irrelevant for end users since LN is a drop in replacement
JarbasAl added a commit that referenced this pull request Aug 30, 2021
@JarbasAl
patch/locale_switching + packaging/LN+LF_support (#6)(#7)(#27)(#62)
e8a715f 
- integration of timezone support with LN (was a dummy method until now)
- lingua_franca and lingua_nostra need to be able to coexist
	- skills might be importing one of those libs directly
- mycroft-lib will call property setters (lang/timezone) for both libs if possible
- all other wrapped methods (`mycroft.util.parse` + `mycroft.util.format` + `mycroft.util.time`) will give preference to LN if it is available, use LF otherwise
	- this should be irrelevant for end users since LN is a drop in replacement
JarbasAl added a commit that referenced this pull request Aug 30, 2021
@JarbasAl
patch/locale_switching + packaging/LN+LF_support (#6)(#7)(#27)(#62)
194594b 
- integration of timezone support with LN (was a dummy method until now)
- lingua_franca and lingua_nostra need to be able to coexist
	- skills might be importing one of those libs directly
- mycroft-lib will call property setters (lang/timezone) for both libs if possible
- all other wrapped methods (`mycroft.util.parse` + `mycroft.util.format` + `mycroft.util.time`) will give preference to LN if it is available, use LF otherwise
	- this should be irrelevant for end users since LN is a drop in replacement
JarbasAl added a commit that referenced this pull request Sep 8, 2021
@JarbasAl
patch/locale_switching + packaging/LN+LF_support (#6)(#7)(#27)(#62)
5bf3f6b 
- integration of timezone support with LN (was a dummy method until now)
- lingua_franca and lingua_nostra need to be able to coexist
	- skills might be importing one of those libs directly
- mycroft-lib will call property setters (lang/timezone) for both libs if possible
- all other wrapped methods (`mycroft.util.parse` + `mycroft.util.format` + `mycroft.util.time`) will give preference to LN if it is available, use LF otherwise
	- this should be irrelevant for end users since LN is a drop in replacement
JarbasAl added a commit that referenced this pull request Sep 8, 2021
@JarbasAl
patch/locale_switching + packaging/LN+LF_support (#6)(#7)(#27)(#62)
c6c1a40 
- integration of timezone support with LN (was a dummy method until now)
- lingua_franca and lingua_nostra need to be able to coexist
	- skills might be importing one of those libs directly
- mycroft-lib will call property setters (lang/timezone) for both libs if possible
- all other wrapped methods (`mycroft.util.parse` + `mycroft.util.format` + `mycroft.util.time`) will give preference to LN if it is available, use LF otherwise
	- this should be irrelevant for end users since LN is a drop in replacement
JarbasAl added a commit that referenced this pull request Sep 8, 2021
@JarbasAl
patch/locale_switching + packaging/LN+LF_support (#6)(#7)(#27)(#62)
431f5e1 
- integration of timezone support with LN (was a dummy method until now)
- lingua_franca and lingua_nostra need to be able to coexist
	- skills might be importing one of those libs directly
- mycroft-lib will call property setters (lang/timezone) for both libs if possible
- all other wrapped methods (`mycroft.util.parse` + `mycroft.util.format` + `mycroft.util.time`) will give preference to LN if it is available, use LF otherwise
	- this should be irrelevant for end users since LN is a drop in replacement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
packaging refactored for packaging reasons patch not present in upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JarbasAl