Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

71 refacto menu buttons #72

Merged
merged 3 commits into from
Jan 11, 2025
Merged

71 refacto menu buttons #72

merged 3 commits into from
Jan 11, 2025

Conversation

Lucaslgd02
Copy link
Contributor

Describe your changes

Refactorization of the Footer's buttons as the KDS

Issue ticket number and link

Closes #71

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have performed a self-review of my code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Documentation has been updated as required
    If a single item in this checklist is not checked, the pull request cannot be accepted

@Lucaslgd02 Lucaslgd02 self-assigned this Dec 19, 2024
@Lucaslgd02 Lucaslgd02 requested a review from alecorvec December 19, 2024 07:14
@JulesGresset JulesGresset linked an issue Dec 19, 2024 that may be closed by this pull request
@JulesGresset JulesGresset self-requested a review December 22, 2024 20:05
Copy link
Member

@JulesGresset JulesGresset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icons colors and text size are not compliant with the mockup.

@JulesGresset JulesGresset merged commit 17ad31c into dev Jan 11, 2025
5 checks passed
@JulesGresset JulesGresset deleted the 71-refacto-menu-buttons branch January 11, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refacto menu buttons
2 participants