feat/135/obfuscation #152
Open
feat/135/obfuscation #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… before returning.
… infinite loop on SubmitResults for any error other than 500.
Added Obfuscate function to apply obfuscation steps.
…on, to ensure that it is always called whenever the results are retrieved.
…on, to ensure that it is always called whenever the results are retrieved.
…ut on other errors will fail immediately, rather than going into an infinite loop, as before. Other errors are also logged.
# Conflicts: # app/Hutch.Relay/Controllers/TaskController.cs # app/Hutch.Relay/Services/Contracts/IObfuscationService.cs # app/Hutch.Relay/Services/ObfuscationService.cs # app/Hutch.Relay/Services/ResultsService.cs # app/Hutch.Relay/Startup/Web/ConfigureWebService.cs # compose.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Contents
Description
Refactored obfuscation to have a separate function, and for that to be called from AggregateResults.
ObfuscationOptions moved into Obfuscation service.
Bug fixed in submit results which caused an infinite loop on any http error (other than 500). This is also logged.
Related Issues or other material
Screenshots, example outputs/behaviour etc.
✅ Added/updated tests?
[optional] What gif best describes this PR or how it makes you feel?