Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test optimizations #73

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Test optimizations #73

merged 3 commits into from
Sep 16, 2024

Conversation

gershido
Copy link
Contributor

@gershido gershido commented Sep 14, 2024

  • The current Github Action Job that does the testing is using public endpoints for all of the chains. The reason for that is because using non-public endpoints requires using Github Secrets, which are not exposed to Actions that are triggered by PRs from forks. The problem is that these public endpoints are not stable, and thus hard to work with. This PR separates the tests into two Jobs - "test-fork" and "test-branch". Each runs the same tests but "test-fork" is using the public endpoints and "test-branch" is using the non-public endpoints. "test-fork" will be triggered only when the PR is from a fork, while "test-branch" will be triggered only when the PR is from a branch on the repo.
  • Change the rate in which we hit the Etherscan API to 1 per-second rather than 3 per-second, due to rate limiting issues that were encountered
  • Improve some error messages

@gershido gershido marked this pull request as ready for review September 14, 2024 12:50
@gershido gershido requested a review from a team as a code owner September 14, 2024 12:50
Copy link
Member

@spengrah spengrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea!

@gershido gershido merged commit f0740ac into submissions Sep 16, 2024
2 checks passed
@gershido gershido deleted the test-optimizations branch September 16, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants