Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primary function prop for Agreement Eligibility roles #50

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Primary function prop for Agreement Eligibility roles #50

merged 2 commits into from
Apr 22, 2024

Conversation

gershido
Copy link
Contributor

@gershido gershido commented Apr 19, 2024 •
edited
Loading

  • Add the primary property for the Owner and Arbitrator roles of the Agreement Eligibility module. This prop is optional and indicates that the function is the primary action of the relevant role.
  • Update the schema validation test to use the Sepolia instead of Goerli

@gershido gershido marked this pull request as ready for review April 19, 2024 21:41
@gershido gershido requested review from a team as code owners April 19, 2024 21:41
YamineRL
YamineRL approved these changes Apr 20, 2024
View reviewed changes
Copy link

@YamineRL YamineRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

spengrah
spengrah approved these changes Apr 21, 2024
View reviewed changes
Copy link
Member

@spengrah spengrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gershido gershido merged commit fae2d14 into main Apr 22, 2024
1 check passed
@gershido gershido deleted the agreement-eligibility-edit branch April 22, 2024 11:39
@gershido gershido restored the agreement-eligibility-edit branch May 29, 2024 12:19
@gershido gershido mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spengrah spengrah spengrah approved these changes

@YamineRL YamineRL YamineRL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gershido @spengrah @YamineRL