Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated tests and bundling #34

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Automated tests and bundling #34

merged 2 commits into from
Jan 17, 2024

Conversation

gershido
Copy link
Contributor

@gershido gershido commented Jan 16, 2024

Two new Github Actions:

  1. Automated bundling - any change in the main branch to one of the module files in the modules folder or one of the infra objects at the infra folder will trigger an automated bundle commit.
  2. Tests - New PRs, including any update to a PR, will trigger automated tests

Implications for module developers:

  • No need to bundle the modules locally
  • Can use the automated tests in addition to testing locally

Implication for module reviewers:

  • No need to run tests locally
  • No need to review the bundled file, just the added module/s

Additional info:

  • The Actions required a small refactor to the bundler script and adjusting the tests accordingly
  • The automated tests will retry on failure, up to 3 times
  • Added a throttle on API requests in the ABI tests, adjusting to Etherscan's rate limits

@gershido gershido requested a review from a team as a code owner January 16, 2024 09:37
@gershido gershido marked this pull request as draft January 16, 2024 09:50
@mulligan-madness
Copy link

Looks goof to me, pending review from someone else with a technicl perspective

Copy link
Member

@spengrah spengrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me as well. Nice work! This is a big QoL improvement for both developers and curators.

@gershido gershido marked this pull request as ready for review January 16, 2024 21:17
@scottrepreneur scottrepreneur linked an issue Jan 17, 2024 that may be closed by this pull request
@gershido gershido merged commit 5d82fc4 into main Jan 17, 2024
1 check passed
@gershido gershido deleted the github-actions branch January 17, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add action to run tests for commits/PRs
4 participants