Enhanced header visibility and improved student section layout #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harshdev098
requested changes
Oct 11, 2024
|
changes done |
Harshdev098
requested changes
Oct 12, 2024
public/index.html
Outdated
| navbar.style.backgroundColor = "rgba(0, 0, 0, 0.8)"; // Dark background on scroll | ||
| navbar.querySelectorAll("a").forEach(a => a.style.color = "white"); // Change link color | ||
| } else { | ||
| navbar.style.backgroundColor = "rgba(0, 0, 0, 0.8)"; // Revert back to light background |
There was a problem hiding this comment.
make the backgroundColor none, it will be good
|
done but again the text almost gets invisible on white background |
|
I have requested to change only the else condition backgroundColor to be none, you have made backgroundColor none to both the conditions |
|
Just wait a minute, will give a solution to it |
|
Just make the backgroundColor to be transparent in the else condition, it will work @Shweta-1902 |
|
done |
Harshdev098
added
hacktoberfest
|
The leaderboard didn't got updated, it shows the same score as before |
|
It will be get updated soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Description
This pull request enhances the visibility of the header to prevent text from fading, ensuring a better user experience. Additionally, I've made several improvements to the student section layout, including better use of background colors and more detailed content for each student.
🔨 Changes Made
Improved header visibility to enhance text clarity and readability.
Enhanced the student section layout to ensure it occupies the entire box.
Increased the content for each student profile to fill the designated area effectively.
Updated images for student profiles with valid links.
Adjusted the overall styling for a more cohesive and appealing appearance.
✅ Checklist
Before submitting the PR, please make sure you have completed the following:
I have followed all the guidelines mentioned in CONTRIBUTING.md.
My code follows the style guidelines of this project.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have made corresponding changes to the documentation (if applicable).
I have tested it locally and it works fine.
Any dependent changes have been merged and published in downstream modules.
🏷️ Types of Changes
What type of changes does your code introduce? (Check all that apply)
UI enhancement (non-breaking change which enhances UI) 🎨
📸 Screenshots (if applicable)
Thank you for contributing to Research Nexus! We look forward to reviewing your PR and getting it merged!