-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on deprecated system-filepath #70
base: master
Are you sure you want to change the base?
Conversation
5e67e18
to
1fd0069
Compare
The ability to resolve How to implement This patch is an attempt to address this question. |
1fd0069
to
e6837bb
Compare
I added a test for the |
47dea0b
to
f4d6a08
Compare
This patch removes `system-filepath` and tries to replace any existing functionality that that package provides. `system-filepath` has been deprecated in favor of `filepath`: https://hackage.haskell.org/package/system-filepath
`hie.yaml` is generated by [implicit-hie][1], part of the [haskell-language-server][2] project. [1]: https://github.com/Avi-D-coder/implicit-hie#readme [2]: https://github.com/haskell/haskell-language-server
b5484df
to
aff4c78
Compare
I tried the patch on Linux and it seems to work as expected. I used this:
I noticed that I also tried testing it on Windows (wanted to see what happens if I read a pseudo-file like
So I think this looks good. Why is it marked as a draft @hololeap ? |
I am also looking at what is keeping |
What exactly was the input you were giving it, and what was the behavior you expected? |
@hololeap With this server On the other hand, I guess it isn't causing any trouble in this concrete example. I'm more worried about pseudo-files on Windows. But I guess we could also just remove Windows support, I doubt anybody uses it. |
Thanks for getting the ball rolling on this! Would definitely like to pull it into main once the issues are worked out. |
Go ahead and pull this if it seems good. There doesn't seem to be much activity regarding Gabriella439/turtle#54. |
This patch removes
system-filepath
and tries to replace any existing functionality that that package provides.system-filepath
has been deprecated in favor offilepath
:https://hackage.haskell.org/package/system-filepath