Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txt format will use default icon, because CMakeLists.txt should use cmake icon #3761

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

Steve-Li-1998
Copy link
Contributor

@Steve-Li-1998 Steve-Li-1998 commented Nov 20, 2024

Fix #3674

Summary of additions and changes

I comment the case for txt, so I think the the icon of txt will use the defualt configuration of clion (CMakeLists.txt will use cmake icon) to solve this issue #3674
But I don't know how to build the plugin, so I haven't test the result. Since the changes are very simple(only 1 line), I hope you can test for me:) thanks a lot!
*

How to test this pull request

  • Updated the documentation, or no update necessary
  • Added tests, or no tests necessary

txt format will use default icon, because CMakeLists.txt should use cmake icon
@PHPirates PHPirates added this to the Next milestone Nov 21, 2024
Copy link
Collaborator

@PHPirates PHPirates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I agree, I have no idea why we had a file type for .txt files, as those have nothing to do with LaTeX.
I removed the code instead of commenting it out.

@PHPirates PHPirates enabled auto-merge November 21, 2024 18:00
@PHPirates PHPirates merged commit b12eb24 into Hannah-Sten:master Nov 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clion: file type icon for CMakeLists.txt breaks when enabling plugin
3 participants