Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xdg-mime to choose a default pdf viewer in the run configuration template #3746

Merged
merged 1 commit into from
Nov 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## [Unreleased]

### Added
* Use xdg-mime to choose a default pdf viewer in the run configuration template

### Fixed

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,17 @@ enum class InternalPdfViewer(
// These properties may be used often when opening a project or during project use because of settings state initialization, so we cache them.
val availableSubset: List<InternalPdfViewer> by lazy { entries.filter { it.isAvailable() } }

val firstAvailable: InternalPdfViewer by lazy { availableSubset.first() }
val firstAvailable: InternalPdfViewer by lazy {
// Use system default if possible
if (SystemInfo.isLinux) {
// e.g. okularApplication_pdf.desktop or org.gnome.Evince.desktop
runCommand("xdg-mime", "query", "default", "application/pdf", timeout = 1)?.let {
availableSubset.firstOrNull { viewer -> viewer.name.lowercase() in it.lowercase() }
} ?: availableSubset.first()
}
else {
availableSubset.first()
}
}
}
}
Loading