Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix equation gathering #3386

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Fix equation gathering #3386

merged 2 commits into from
Jan 11, 2024

Conversation

jojo2357
Copy link
Contributor

@jojo2357 jojo2357 commented Jan 8, 2024

Fix #3321

Previously, the \item{\[a=b\]} was returning true from isDisplayMath due to it not caring about the depth that the DisplayMath child was. This fix passed all tests locally by requiring the math child to be at a depth of exactly 1.

What should this do?

\begin{enumerate}
    \item{ \[a=b\] \[b=a\] }
\end{enumerate}

right now it does not error and there is no test for it.

@PHPirates PHPirates added this to the Next milestone Jan 11, 2024
@PHPirates PHPirates merged commit 5ee64bc into Hannah-Sten:master Jan 11, 2024
10 checks passed
@jojo2357 jojo2357 deleted the gathering branch January 12, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Wrong) suggestion to gather equations across different \items
2 participants