Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React 19 #5300

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Upgrade to React 19 #5300

merged 4 commits into from
Jan 6, 2025

Conversation

martijnrusschen
Copy link
Member

Closes #5299

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

Check the status or cancel PullRequest code review here.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 34
- 50

65% JSON
35% TSX

Generated lines of change

+ 63
- 86

Type of change

Feature - These changes are adding a new feature or improvement to existing code.

@martijnrusschen
Copy link
Member Author

@balajis-qb here's a start. just need to fix the type checks that got changed. Haven't gotten to those yet.

Balaji-Sridharan_NYULH and others added 2 commits January 6, 2025 16:02
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.93%. Comparing base (66ab790) to head (011c335).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5300   +/-   ##
=======================================
  Coverage   96.93%   96.93%           
=======================================
  Files          29       29           
  Lines        3389     3390    +1     
  Branches     1419     1415    -4     
=======================================
+ Hits         3285     3286    +1     
- Misses        102      104    +2     
+ Partials        2        0    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martijnrusschen martijnrusschen merged commit 601131e into main Jan 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade docs-site to React 19
1 participant