-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump date-fns from 3.6.0 to 4.1.0 #5177
base: main
Are you sure you want to change the base?
Conversation
Bumps [date-fns](https://github.com/date-fns/date-fns) from 3.6.0 to 4.1.0. - [Release notes](https://github.com/date-fns/date-fns/releases) - [Changelog](https://github.com/date-fns/date-fns/blob/main/CHANGELOG.md) - [Commits](date-fns/date-fns@v3.6.0...v4.1.0) --- updated-dependencies: - dependency-name: date-fns dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5177 +/- ##
=======================================
Coverage 96.92% 96.92%
=======================================
Files 30 30
Lines 3416 3416
Branches 1427 1427
=======================================
Hits 3311 3311
Misses 105 105 ☔ View full report in Codecov by Sentry. |
Would be great to have this merged, or just change the version in package.json to "^3.6.0 || ^4.1.0". There are pretty much no breaking changes in v4 and after the upgrade in my app I have both versions bundled. |
@balajis-qb Another interesting challenge. This should be pretty simple, but the docs site broke after upgrading the package to V4. |
@martijnrusschen, Sure, I'll check. |
@martijnrusschen , We are facing an issue as [email protected] defaults to ES Module In our Rollup js config we marked One simple solution is to add date-fns to our bundle, by removing it from external config of rollup.config |
Gotcha, I think the tricky part is that including it will increase the bundle size pretty heavily. |
Isn't that a problem with the website, not with the library? Presumably the dependencies are eventually bundled, so it's a responsibility of the end user to process them if necessary. Also ESM should actually work in a browser without any transpilation, as long as the |
Here's a reference to the previous issue which introduced this logic: #1606. If we can get this upgrade in without drastically increasing the bundle size, that would be great. |
Bumps date-fns from 3.6.0 to 4.1.0.
Release notes
Sourced from date-fns's releases.
... (truncated)
Changelog
Sourced from date-fns's changelog.
... (truncated)
Commits
313b902
Fix v4.1.0 change log entry26cd336
Promote to v4.1.097b53b9
Cover time zone edge cases59b7563
Add missing time zone support to format, formatISO, formatISO9075, formatRela...0121164
Prevent constructFrom from throwing an error on nullbd87ef5
Update@date-fns/docs
99b4e67
Prepare v4.08df1706
Rewrite the time zones doce351977
Promote to v4.0.0-beta.18523656
Fix scripts/test/types.shYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)