Upgrade to Eslint 9 #5168
Upgrade to Eslint 9 #5168
Conversation
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
Check the status or cancel PullRequest code review here.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5168 +/- ##
=======================================
Coverage 96.87% 96.87%
=======================================
Files 30 30
Lines 3358 3358
Branches 1427 1428 +1
=======================================
Hits 3253 3253
+ Misses 105 103 -2
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I can't see any issues with this, great work keeping important dependencies and tooling up to date!
Reviewed with ❤️ by PullRequest
There was a problem hiding this comment.
Looks good to me! Keeping a linter up to date is always nice to have.
Reviewed with ❤️ by PullRequest
docs-site/config-overrides.js
Outdated
| @@ -4,25 +4,35 @@ const ModuleScopePlugin = require("react-dev-utils/ModuleScopePlugin"); | |||
| module.exports = function override(config, env) { | |||
| config.resolve.alias["react-datepicker"] = path.resolve(__dirname, ".."); | |||
| config.resolve.alias["react"] = path.resolve(__dirname, "node_modules/react"); | |||
| //do stuff with the webpack config... | |||
|
|
|||
| // Add raw-loader for specific example files | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Due to inactivity, PullRequest has cancelled this review job. You can reactivate the code review job from the PullRequest dashboard.
|
@balajis-qb if you have time, could you help me getting this over the finish line? I got pretty far, but it seems some of the linters aren't working anymore after the changes I made. Need to check that. |
|
@martijnrusschen , Sure, can you please let me know the exact issue? |
|
I need to refresh my memory on this but I believe it only works on the component itself now and not within the docs site. Should give this a try to see if it works as expected. |
|
This should be good to go once the build is happy |
Attempt to upgrade our ESlint config to the latest version.