Added light and dark mode. Update Navbar with search field and other … #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aina21 Could you please review this PR request? |
aina21
reviewed
Apr 11, 2024
| border-radius: 5px; | ||
| text-align: center; | ||
| font-size: 15px; | ||
| width: 35%; |
There was a problem hiding this comment.
Using percentages for layout widths can lead to unpredictable behavior on different devices. Please be aware of this or consider using a more stable approach like flexbox.
aina21
reviewed
Apr 11, 2024
| @@ -1,6 +1,6 @@ | |||
| import React from 'react'; | |||
| import ReactDOM from 'react-dom/client'; | |||
| import './index.css'; | |||
| // import './index.css'; | |||
aina21
approved these changes
Apr 11, 2024
aina21
approved these changes
Apr 11, 2024
| @@ -0,0 +1,50 @@ | |||
| .submitTeam-container { | |||
| display: flex; | |||
| /* justify-content: center; */ | |||
| // import DeleteTeam from '../component/DeleteTeam'; | ||
|
|
||
| const Home = () => { | ||
| const Home = ({theme, setTheme}) => { |
There was a problem hiding this comment.
You can remove the props, as they appear to be unused.
| @@ -0,0 +1,95 @@ | |||
| .navbar{ | |||
| /* width: 100%; */ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…styling as well