react2-week1/Viki #299
Open
react2-week1/Viki #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrantalikP
approved these changes
Apr 17, 2024
|
|
||
| function App() { | ||
| return ( | ||
| <> |
There was a problem hiding this comment.
There is no need to use Fragment, please remove it :)
|
|
||
| return ( | ||
| <div> | ||
| <input |
There was a problem hiding this comment.
Good job! This is just a "pro tip" :D if you wrap the input by form element it also allows you to use keys such as "enter" to search
example:
const handleSearch = (e) => {
e.preventDefault();
fetchUsers();
};
return (
<form onSubmit={handleSearch}>
| setIsLoading(true); | ||
| setError(null); | ||
|
|
||
| fetch(`https://api.github.com/search/users?q=${query}`) |
There was a problem hiding this comment.
if the query is empty it will throw: Error fetching: Failed to fetch users, please handle this scenario
| <> | ||
| <div className="app-container"> | ||
| <h1>Github user searcher</h1> | ||
| <GithubSearchProvider> |
There was a problem hiding this comment.
alternatively (its more common) you can wrap the whole app by the provider, but this is also fine :)
| import { GithubSearchContext } from "../context/GithubSearchContext"; | ||
|
|
||
| const SearchInput = () => { | ||
| const { query, setQuery, fetchUsers } = useContext(GithubSearchContext); |
There was a problem hiding this comment.
the more common way how to access the context could be
// GithubSearchContext.jsx
export const useGithub = () => {
return useContext(GithubSearchContext);
};
// Search Input.jsx
const { query, setQuery, fetchUsers } = useGithub()
But your way is also correct. Well done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github user searcher