-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamped React 1 #68
base: main
Are you sure you want to change the base?
Revamped React 1 #68
Conversation
…o react1-revamp
React 1 new Homework
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Genuinely amazing! Hope it worked well at the weekend too. I guess things will be tweaked over the following weeks but here's a few comments and additional points here:
- It looks like there are now some unused assets we could remove too? Check each of the assets folders, think there is some in each one
- Should we have a "homework.md" in each week for consistency? Or remove it from react1 week1 too?
- Is "react2/readme.md" week 1 topic still accurate? Or should we replace "render props" with "nextjs router"? 🤔
Super nice! Good catches and thank you! Yes, this weekend was amazing, thanks to our superstars @bhas and @ddobby94. I addressed these issues.
|
@chezzoba Fab! I'll approve it for merge, if you can take care of point 3 soon so we don't leave the official docs out of date for too long. Huge thanks again! Excited to hear how it goes over the next weeks 🙌 P.s. If you don't have permission to merge it, just tell me when and I can do it! |
The curriculum is now completely revamped and ready for testing on the guinea pigs we call team28!
For a summary of the revamped React curriculum and lesson plans view this planning document.