Add ability to view all requests and create/edit requests #146
Conversation
There was a problem hiding this comment.
Really excited about this! Few notes about the code and/or being picky about phrasing mostly. Also, seems like you fixed #125 😊 with that network-only change on the GraphQL subscription. Only time will tell, but hopefully that also helps with the intermittent issues @michaelraman has had at events with the hardware desk screen not updating for him.
Also, some UX notes from testing it out:
- Can you add a create request button to the main hardware desk screen?
- This date format is a little weird. I'd prefer either the same relative date/time component used by the hardware desk screen or else a more standard date/time format
- Can you make these status representations use similar colors/styles to how users see them on the home page? (At a minimum, they should be Title Case, e.g., Ready for Pickup). If you look at the Bolt documentation on Confluence, that also provides some nice examples of ways to show pretty statuses
- Eventually, date and status filters would be nice to have on the Manage Requests screen. I like the search functionality, but some help text to let users know they can search by everything except date would be helpful. Filtering by typing in a status also isn't ideal, since you might want to find Person A's declined requests
- Is it possible to edit request statuses? For instance, if you accidentally mark something returned or want to cancel a request for a user
You don't necessarily have to do all of the above in this PR. That being said, these little UI touches and tweaks are big contributors to Bolt's relative simplicity and ease of use, so it's important to think about it when adding new features.
| <Form.Group> | ||
| <Form.Field width={4}> | ||
| <Popup | ||
| inverted | ||
| trigger={<label>Unreserved</label>} | ||
| content="The number of an item that is not reserved" | ||
| /> | ||
| <p>{selectedItem?.qtyUnreserved}</p> | ||
| </Form.Field> | ||
| <Form.Field width={4}> | ||
| <Popup | ||
| inverted | ||
| trigger={<label>In stock</label>} | ||
| content="The number of an item that should be physically at the hardware desk" | ||
| /> | ||
| <p>{selectedItem?.qtyInStock}</p> | ||
| </Form.Field> | ||
| <Form.Field width={4}> | ||
| <Popup | ||
| inverted | ||
| trigger={<label>Available for approval</label>} | ||
| content="The number of an item that is available to be allocated to requests waiting to be approved" | ||
| /> | ||
| <p>{selectedItem?.qtyAvailableForApproval}</p> | ||
| </Form.Field> | ||
| </Form.Group> |
There was a problem hiding this comment.
You should refactor this into a few separate components so the explanations don't have to be repeated every time. (I'd suggest a component for all the quantity indications as a group plus a component defining a single quantity indication with optional explanation.)
Changes
Screenshots
Create Requets
Request List
Show warning when request quantity exceeded
Resolved issues
Closes #101
Adds to #76