Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stats (Origin stats) #295

Merged
merged 10 commits into from
Mar 22, 2020
Merged

Conversation

raquelpanapalen
Copy link
Contributor

@raquelpanapalen raquelpanapalen commented Mar 22, 2020

What this PR does / Why we need it

Adding origin stats by numbers

Which issue(s) this PR fixes (optional)

References #103

Special notes for your reviewer (optional)

Some questions

  • I have read the contributing guidelines
  • I abide by this repository Code of Conduct
  • I understand that my PR won't be merged until GitHub gives a "green light"

Additional Notes (optional)

Do you want to add anything else? We ❤️ to hear your opinions!

@casassg casassg temporarily deployed to hackassistan-master-viax9smwxe March 22, 2020 17:45 Inactive
@casassg casassg temporarily deployed to hackassistan-master-viax9smwxe March 22, 2020 17:46 Inactive
Copy link
Member

@casassg casassg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, suggestion regarding how to make it more readable.

type: 'category'
}
}
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepting, but this may get difficult to read when there are a lot of people from diverse origins.

A suggestion would be to show top 5-10 in the graph + the rest as a table (hidden by default, toggle to see it).

@Casassarnau
Copy link
Member

Casassarnau commented Mar 22, 2020

Change in descripton Fixes #103 to References #103 pls
Fixes will close de issue.

@casassg casassg temporarily deployed to hackassistan-master-viax9smwxe March 22, 2020 18:52 Inactive
@casassg casassg temporarily deployed to hackassistan-master-viax9smwxe March 22, 2020 19:13 Inactive
@Casassarnau Casassarnau merged commit e8dae8a into HackAssistant:master Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants