Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alternatives for # 14461 issue #14483

Closed
wants to merge 3 commits into from
Closed

alternatives for # 14461 issue #14483

wants to merge 3 commits into from

Conversation

iagocabral
Copy link

possibility of testing to fix the problem of issue number #14461

Copy link
Member

@SabreCat SabreCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @iagocabral --

This PR doesn't give us much to work with at Habitica HQ unfortunately..

  • The PR is missing a description; how does this address the referenced issue? It just looks to be a couple of self-referential unit tests?
  • While Habitica is translated into numerous languages, to varying degrees of completeness, the code base is in English. Tests and variables in other languages will be hard for the team to use.

@SabreCat SabreCat marked this pull request as draft February 13, 2023 22:03
@iagocabral iagocabral closed this by deleting the head repository Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants