bugfix: unable to communicate with LSP on Windows 10 (#155)

* use SecurityIdentifier everyone * bumped version to 2.0.1.0
HJLebbink · Feb 11, 2024 · 2b08ac0 · 2b08ac0
1 parent 095211d
commit 2b08ac0
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 25 deletions.
diff --git a/VS/CSHARP/asm-dude2-ls/Worker.cs b/VS/CSHARP/asm-dude2-ls/Worker.cs
@@ -1,5 +1,6 @@
 using System.IO.Pipes;
 using System.Runtime.InteropServices;
+using System.Security.Principal;
 
 namespace AsmDude2LS;
 
@@ -34,7 +35,8 @@ public Worker(ILogger<Worker> logger)
         const string stdInPipeName = @"input";
         const string stdOutPipeName = @"output";
 
-        PipeAccessRule pipeAccessRule = new("Everyone", PipeAccessRights.ReadWrite, System.Security.AccessControl.AccessControlType.Allow);
+        SecurityIdentifier everyone = new(WellKnownSidType.WorldSid, null);
+        PipeAccessRule pipeAccessRule = new(everyone, PipeAccessRights.ReadWrite, System.Security.AccessControl.AccessControlType.Allow);
         PipeSecurity pipeSecurity = new();
         pipeSecurity.AddAccessRule(pipeAccessRule);
 

diff --git a/VS/CSHARP/asm-dude2-ls/lsp-version.txt b/VS/CSHARP/asm-dude2-ls/lsp-version.txt
@@ -1 +1 @@
-1.0.0.4
+1.0.1.0
diff --git a/VS/CSHARP/asm-dude2-vsix/AsmLanguageClient.cs b/VS/CSHARP/asm-dude2-vsix/AsmLanguageClient.cs
@@ -36,6 +36,7 @@
 using AsmDude2.Tools;
 using AsmTools;
 using System.Windows.Forms;
+using System.Security.Principal;
 
 namespace AsmDude2
 {
@@ -261,8 +262,9 @@ public async Task<Connection> ActivateAsync(CancellationToken token)
             const string stdInPipeName = @"output";
             const string stdOutPipeName = @"input";
 
-            var pipeAccessRule = new PipeAccessRule("Everyone", PipeAccessRights.ReadWrite, System.Security.AccessControl.AccessControlType.Allow);
-            var pipeSecurity = new PipeSecurity();
+            SecurityIdentifier everyone = new SecurityIdentifier(WellKnownSidType.WorldSid, null); 
+            PipeAccessRule pipeAccessRule = new PipeAccessRule(everyone, PipeAccessRights.ReadWrite, System.Security.AccessControl.AccessControlType.Allow);
+            PipeSecurity pipeSecurity = new PipeSecurity();
             pipeSecurity.AddAccessRule(pipeAccessRule);
 
             var bufferSize = 256;

diff --git a/VS/CSHARP/asm-dude2-vsix/Properties/AssemblyInfo.cs b/VS/CSHARP/asm-dude2-vsix/Properties/AssemblyInfo.cs
diff --git a/VS/CSHARP/asm-dude2-vsix/asmdude2-version.txt b/VS/CSHARP/asm-dude2-vsix/asmdude2-version.txt
@@ -1 +1 @@
-2.0.0.5
+2.0.1.0
diff --git a/VS/CSHARP/asm-dude2-vsix/source.extension.vsixmanifest b/VS/CSHARP/asm-dude2-vsix/source.extension.vsixmanifest
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
     <Metadata>
-        <Identity Id="AsmDude2" Version="2.0.0.5" Language="en-US" Publisher="Henk-Jan Lebbink" />
+        <Identity Id="AsmDude2" Version="2.0.1.0" Language="en-US" Publisher="Henk-Jan Lebbink" />
         <DisplayName>AsmDude2</DisplayName>
 		<Description xml:space="preserve">Syntax highlighting and code assistance for assembly source code (.asm, .cod, .inc, .s) and the Disassembly Window.</Description>
     </Metadata>